qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: tiwai@suse.de, Gerd Hoffmann <kraxel@redhat.com>,
	Cole Robinson <crobinso@redhat.com>
Subject: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode
Date: Wed,  2 Apr 2014 11:07:44 -0400	[thread overview]
Message-ID: <6654339de9ab8191d7a11ce68194b9cd27471d54.1396451183.git.crobinso@redhat.com> (raw)
In-Reply-To: <1396449543.31715.7.camel@nilsson.home.kraxel.org>

Without this, we need to initiate a manual grab with ctrl+alt+g just
to get a usable mouse.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
Gerd, Takashi, I think this should do what we want.

 ui/gtk.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/ui/gtk.c b/ui/gtk.c
index 9b8df12..ebaade2 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -685,6 +685,15 @@ static gboolean gd_button_event(GtkWidget *widget, GdkEventButton *button,
     GtkDisplayState *s = opaque;
     InputButton btn;
 
+    if (button->button == 1 &&
+        button->type == GDK_BUTTON_PRESS &&
+        !gd_is_grab_active(s) &&
+        !qemu_input_is_absolute()) {
+        gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item),
+                                       TRUE);
+        return TRUE;
+    }
+
     if (button->button == 1) {
         btn = INPUT_BUTTON_LEFT;
     } else if (button->button == 2) {
-- 
1.9.0

  reply	other threads:[~2014-04-02 15:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 12:32 [Qemu-devel] [PATCH v2 0/4] Fix relative pointer tracking on Gtk UI (v2) Takashi Iwai
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event Takashi Iwai
2014-04-02 13:25   ` Cole Robinson
2014-04-02 15:17   ` Gerd Hoffmann
2014-04-02 15:26     ` Takashi Iwai
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode Takashi Iwai
2014-04-02 13:26   ` Cole Robinson
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 3/4] gtk: Remember the last grabbed pointer position Takashi Iwai
2014-04-02 13:27   ` Cole Robinson
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option Takashi Iwai
2014-04-02 13:28   ` Cole Robinson
2014-04-02 13:42     ` Takashi Iwai
2014-04-02 13:49       ` Cole Robinson
2014-04-02 14:39     ` Gerd Hoffmann
2014-04-02 15:07       ` Cole Robinson [this message]
2014-04-02 15:19         ` [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode Gerd Hoffmann
2014-04-02 15:25           ` Takashi Iwai
2014-04-02 20:18             ` Cole Robinson
2014-04-03  6:19               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6654339de9ab8191d7a11ce68194b9cd27471d54.1396451183.git.crobinso@redhat.com \
    --to=crobinso@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).