From: Paolo Bonzini <pbonzini@redhat.com>
To: "Jason Wang" <jasowang@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] slirp: use exit notifier for slirp_smb_cleanup
Date: Wed, 13 Jul 2016 09:40:37 +0200 [thread overview]
Message-ID: <6660c184-c8f2-f9dc-2d0e-459611bf9ec9@redhat.com> (raw)
In-Reply-To: <5785A8CF.6010301@redhat.com>
On 13/07/2016 04:34, Jason Wang wrote:
>
>
> On 2016年07月12日 18:15, Marc-André Lureau wrote:
>> Hi
>>
>> On Tue, Jul 12, 2016 at 11:23 AM, Paolo Bonzini <pbonzini@redhat.com>
>> wrote:
>>> We would like to move back net_cleanup() at the end of main function,
>>> like it used to be until f30dbae63a46f23116715dff8d130c, but minimum
>>> cleanup is needed regardless at exit() time for slirp's SMB
>>> functionality. Use an exit notifier to call slirp_smb_cleanup.
>>> If net_cleanup() is called first, then remove the exit notifier as it
>>> will become a dangling pointer otherwise.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Reviewed-by: Jason Wang <jasowang@redhat.com>
Thanks!
Paolo
prev parent reply other threads:[~2016-07-13 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 9:23 [Qemu-devel] [PATCH] slirp: use exit notifier for slirp_smb_cleanup Paolo Bonzini
2016-07-12 10:15 ` Marc-André Lureau
2016-07-13 2:34 ` Jason Wang
2016-07-13 7:40 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6660c184-c8f2-f9dc-2d0e-459611bf9ec9@redhat.com \
--to=pbonzini@redhat.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).