From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNEmi-0002PA-E1 for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:40:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNEmg-0004KI-Ij for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:40:43 -0400 Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]:32850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNEmg-0004K6-3N for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:40:42 -0400 Received: by mail-lf0-x22f.google.com with SMTP id b199so31892648lfe.0 for ; Wed, 13 Jul 2016 00:40:41 -0700 (PDT) Sender: Paolo Bonzini References: <1468315413-22846-1-git-send-email-pbonzini@redhat.com> <5785A8CF.6010301@redhat.com> From: Paolo Bonzini Message-ID: <6660c184-c8f2-f9dc-2d0e-459611bf9ec9@redhat.com> Date: Wed, 13 Jul 2016 09:40:37 +0200 MIME-Version: 1.0 In-Reply-To: <5785A8CF.6010301@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] slirp: use exit notifier for slirp_smb_cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Cc: QEMU On 13/07/2016 04:34, Jason Wang wrote: > > > On 2016年07月12日 18:15, Marc-André Lureau wrote: >> Hi >> >> On Tue, Jul 12, 2016 at 11:23 AM, Paolo Bonzini >> wrote: >>> We would like to move back net_cleanup() at the end of main function, >>> like it used to be until f30dbae63a46f23116715dff8d130c, but minimum >>> cleanup is needed regardless at exit() time for slirp's SMB >>> functionality. Use an exit notifier to call slirp_smb_cleanup. >>> If net_cleanup() is called first, then remove the exit notifier as it >>> will become a dangling pointer otherwise. >>> >>> Signed-off-by: Paolo Bonzini >> Reviewed-by: Marc-André Lureau > > Reviewed-by: Jason Wang Thanks! Paolo