qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Bruce Rogers <brogers@suse.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, christian.ehrhardt@canonical.com
Subject: Re: [PATCH] module: increase dirs array size by one
Date: Sat, 11 Apr 2020 07:49:08 +0200	[thread overview]
Message-ID: <66713300-eebd-d9a4-62fd-f355e6ca4e07@redhat.com> (raw)
In-Reply-To: <20200411010746.472295-1-brogers@suse.com>

On 11/04/20 03:07, Bruce Rogers wrote:
> With the module upgrades code change, the statically sized dirs array
> can now overflow. Increase it's size by one, according to the new
> maximum possible usage.
> 
> Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir")
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>  util/module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/util/module.c b/util/module.c
> index 5f7896870a..e48d9aacc0 100644
> --- a/util/module.c
> +++ b/util/module.c
> @@ -177,7 +177,7 @@ bool module_load_one(const char *prefix, const char *lib_name)
>      char *version_dir;
>  #endif
>      const char *search_dir;
> -    char *dirs[4];
> +    char *dirs[5];
>      char *module_name;
>      int i = 0, n_dirs = 0;
>      int ret;
> 

Queued, thanks.

Paolo



      reply	other threads:[~2020-04-11  5:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-11  1:07 [PATCH] module: increase dirs array size by one Bruce Rogers
2020-04-11  5:49 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66713300-eebd-d9a4-62fd-f355e6ca4e07@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=brogers@suse.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).