* [PATCH] module: increase dirs array size by one
@ 2020-04-11 1:07 Bruce Rogers
2020-04-11 5:49 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Bruce Rogers @ 2020-04-11 1:07 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, berrange, christian.ehrhardt, Bruce Rogers
With the module upgrades code change, the statically sized dirs array
can now overflow. Increase it's size by one, according to the new
maximum possible usage.
Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir")
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
util/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/module.c b/util/module.c
index 5f7896870a..e48d9aacc0 100644
--- a/util/module.c
+++ b/util/module.c
@@ -177,7 +177,7 @@ bool module_load_one(const char *prefix, const char *lib_name)
char *version_dir;
#endif
const char *search_dir;
- char *dirs[4];
+ char *dirs[5];
char *module_name;
int i = 0, n_dirs = 0;
int ret;
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] module: increase dirs array size by one
2020-04-11 1:07 [PATCH] module: increase dirs array size by one Bruce Rogers
@ 2020-04-11 5:49 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-04-11 5:49 UTC (permalink / raw)
To: Bruce Rogers, qemu-devel; +Cc: berrange, christian.ehrhardt
On 11/04/20 03:07, Bruce Rogers wrote:
> With the module upgrades code change, the statically sized dirs array
> can now overflow. Increase it's size by one, according to the new
> maximum possible usage.
>
> Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir")
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> util/module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/module.c b/util/module.c
> index 5f7896870a..e48d9aacc0 100644
> --- a/util/module.c
> +++ b/util/module.c
> @@ -177,7 +177,7 @@ bool module_load_one(const char *prefix, const char *lib_name)
> char *version_dir;
> #endif
> const char *search_dir;
> - char *dirs[4];
> + char *dirs[5];
> char *module_name;
> int i = 0, n_dirs = 0;
> int ret;
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-11 5:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-11 1:07 [PATCH] module: increase dirs array size by one Bruce Rogers
2020-04-11 5:49 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).