Re: [Qemu-devel] [PATCH v2] file-posix: Don't leak fd in hdev_get_max_segments

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

On 03/14/2017 11:12 AM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/file-posix.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/block/file-posix.c b/block/file-posix.c
> index c4c0663..d670be3 100644
> --- a/block/file-posix.c
> +++ b/block/file-posix.c
> @@ -703,6 +703,9 @@ static int hdev_get_max_segments(const struct stat *st)
>      }
>  
>  out:
> +    if (fd != -1) {
> +        close(fd);
> +    }

Mails crossed - I see I asked about this in reply to v1 after you
already sent v2 minutes earlier.

I still think it might be nice to mention a commit id that you are
fixing (one of my reply-to-self on your v1), but either way,

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]