[PATCH] docs/about: Deprecate the "mainstone", "tosa" and "z2" machines

[PATCH] docs/about: Deprecate the "mainstone", "tosa" and "z2" machines

[Thomas Huth]

Support for these boards has been removed from the Linux kernel
in version 6.3 in 2023, so there are likely no users left for these
boards. Time to mark them as deprecated in QEMU, too!

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 docs/about/deprecated.rst | 8 ++++++++
 hw/arm/mainstone.c        | 1 +
 hw/arm/tosa.c             | 1 +
 hw/arm/z2.c               | 1 +
 4 files changed, 11 insertions(+)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 8565644da6..da5cc91eec 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -247,6 +247,14 @@ to correct issues, mostly regarding migration compatibility. These are
 no longer maintained and removing them will make the code easier to
 read and maintain. Use versions 2.12 and above as a replacement.
 
+``mainstone``, ``tosa`` and ``z2`` PXA2xx arm machines (since 9.0)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Support for these boards has been removed from the Linux kernel
+in version 6.3 in 2023, so there are likely no users left for these
+boards, thus they will be removed without replacement.
+
+
 Backend options
 ---------------
 
diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c
index d2e2e68aa3..c6018c6e81 100644
--- a/hw/arm/mainstone.c
+++ b/hw/arm/mainstone.c
@@ -169,6 +169,7 @@ static void mainstone2_machine_init(MachineClass *mc)
     mc->init = mainstone_init;
     mc->ignore_memory_transaction_failures = true;
     mc->default_cpu_type = ARM_CPU_TYPE_NAME("pxa270-c5");
+    mc->deprecation_reason = "machine is old and has no more Linux kernel support";
 }
 
 DEFINE_MACHINE("mainstone", mainstone2_machine_init)
diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c
index 3ca2e4459c..9241867ba9 100644
--- a/hw/arm/tosa.c
+++ b/hw/arm/tosa.c
@@ -270,6 +270,7 @@ static void tosapda_machine_init(MachineClass *mc)
     mc->init = tosa_init;
     mc->block_default_type = IF_IDE;
     mc->ignore_memory_transaction_failures = true;
+    mc->deprecation_reason = "machine is old and has no more Linux kernel support";
 }
 
 DEFINE_MACHINE("tosa", tosapda_machine_init)
diff --git a/hw/arm/z2.c b/hw/arm/z2.c
index eb2ff8dbc8..c7c26bd726 100644
--- a/hw/arm/z2.c
+++ b/hw/arm/z2.c
@@ -347,6 +347,7 @@ static void z2_machine_init(MachineClass *mc)
     mc->init = z2_init;
     mc->ignore_memory_transaction_failures = true;
     mc->default_cpu_type = ARM_CPU_TYPE_NAME("pxa270-c5");
+    mc->deprecation_reason = "machine is old and has no more Linux kernel support";
 
     machine_add_audiodev_property(mc);
 }
-- 
2.44.0

Re: [PATCH] docs/about: Deprecate the "mainstone", "tosa" and "z2" machines

[Peter Maydell]

On Fri, 8 Mar 2024 at 10:42, Thomas Huth <thuth@redhat.com> wrote:
>
> Support for these boards has been removed from the Linux kernel
> in version 6.3 in 2023, so there are likely no users left for these
> boards. Time to mark them as deprecated in QEMU, too!
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  docs/about/deprecated.rst | 8 ++++++++
>  hw/arm/mainstone.c        | 1 +
>  hw/arm/tosa.c             | 1 +
>  hw/arm/z2.c               | 1 +
>  4 files changed, 11 insertions(+)

I agree that we should drop these, but I would like to be more
drastic -- see my other email in the "possible deprecation and
removal of some old QEMU Arm machine types (pxa2xx, omap, sa1110)"
thread.

thanks
-- PMM

Re: [PATCH] docs/about: Deprecate the "mainstone", "tosa" and "z2" machines

[Thomas Huth]

On 08/03/2024 16.43, Peter Maydell wrote:
> On Fri, 8 Mar 2024 at 10:42, Thomas Huth <thuth@redhat.com> wrote:
>>
>> Support for these boards has been removed from the Linux kernel
>> in version 6.3 in 2023, so there are likely no users left for these
>> boards. Time to mark them as deprecated in QEMU, too!
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   docs/about/deprecated.rst | 8 ++++++++
>>   hw/arm/mainstone.c        | 1 +
>>   hw/arm/tosa.c             | 1 +
>>   hw/arm/z2.c               | 1 +
>>   4 files changed, 11 insertions(+)
> 
> I agree that we should drop these, but I would like to be more
> drastic -- see my other email in the "possible deprecation and
> removal of some old QEMU Arm machine types (pxa2xx, omap, sa1110)"
> thread.

Even better! Looking forward to your patch :-)

  Thomas

Re: [PATCH] docs/about: Deprecate the "mainstone", "tosa" and "z2" machines

[Philippe Mathieu-Daudé]

Hi Thomas,

On 8/3/24 11:42, Thomas Huth wrote:
> Support for these boards has been removed from the Linux kernel
> in version 6.3 in 2023, so there are likely no users left for these
> boards. Time to mark them as deprecated in QEMU, too!
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   docs/about/deprecated.rst | 8 ++++++++
>   hw/arm/mainstone.c        | 1 +
>   hw/arm/tosa.c             | 1 +
>   hw/arm/z2.c               | 1 +
>   4 files changed, 11 insertions(+)
> 
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 8565644da6..da5cc91eec 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -247,6 +247,14 @@ to correct issues, mostly regarding migration compatibility. These are
>   no longer maintained and removing them will make the code easier to
>   read and maintain. Use versions 2.12 and above as a replacement.
>   
> +``mainstone``, ``tosa`` and ``z2`` PXA2xx arm machines (since 9.0)
> +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> +
> +Support for these boards has been removed from the Linux kernel
> +in version 6.3 in 2023, so there are likely no users left for these
> +boards, thus they will be removed without replacement.

While Linux host support makes sense for code removal, guest
support isn't relevant IMHO. I.e. you can still run U-boot
or any guest code you fancy, like my-first-rtos.

(I noticed Peter want a more generic removal)