From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Cameron Esfahani <dirty@apple.com>,
Roman Bolshakov <rbolshakov@ddn.com>,
Phil Dennis-Jordan <phil@philjordan.eu>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH] target/i386/hvf: Include missing 'exec/target_page.h' header
Date: Fri, 25 Apr 2025 10:51:37 -0700 [thread overview]
Message-ID: <667613df-e7fe-40ac-ad4c-b57c70b524ea@linaro.org> (raw)
In-Reply-To: <20250425174310.70890-1-philmd@linaro.org>
On 4/25/25 10:43, Philippe Mathieu-Daudé wrote:
> Include "exec/target_page.h" to be able to compile HVF on x86_64:
>
> ../target/i386/hvf/hvf.c:139:49: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
> uint64_t dirty_page_start = gpa & ~(TARGET_PAGE_SIZE - 1u);
> ^
> ../target/i386/hvf/hvf.c:141:45: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
> hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE,
>
> Fixes: 9c2ff9cdc9b ("exec/cpu-all: remove exec/target_page include")
> Reported-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/i386/hvf/hvf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
> index 23ebf2550ac..da1dc66da07 100644
> --- a/target/i386/hvf/hvf.c
> +++ b/target/i386/hvf/hvf.c
> @@ -50,6 +50,7 @@
> #include "qemu/error-report.h"
> #include "qemu/memalign.h"
> #include "qapi/error.h"
> +#include "exec/target_page.h"
> #include "migration/blocker.h"
>
> #include "system/hvf.h"
Thanks for the patch Philippe,
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
prev parent reply other threads:[~2025-04-25 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 17:43 [PATCH] target/i386/hvf: Include missing 'exec/target_page.h' header Philippe Mathieu-Daudé
2025-04-25 17:51 ` Pierrick Bouvier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667613df-e7fe-40ac-ad4c-b57c70b524ea@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=dirty@apple.com \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).