qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Auger <eauger@redhat.com>
To: Yanan Wang <wangyanan55@huawei.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Andrew Jones <drjones@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, Shannon Zhao <shannon.zhaosl@gmail.com>,
	qemu-arm@nongnu.org, Alistair Francis <alistair.francis@wdc.com>,
	wanghaibin.wang@huawei.com,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v8 7/8] hw/arm/virt-acpi-build: Generate PPTT table
Date: Wed, 20 Oct 2021 10:05:11 +0200	[thread overview]
Message-ID: <66786f13-6603-1cdd-7ce7-b1c77f617ac8@redhat.com> (raw)
In-Reply-To: <20211014132206.19220-8-wangyanan55@huawei.com>

Hi

On 10/14/21 3:22 PM, Yanan Wang wrote:
> Generate PPTT table for Arm virt machines.
Generate the Processor Properties Topology Table (PPTT) for ARM virt
machines supporting it (>= 6.2)
> 
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
> ---
>  hw/arm/virt-acpi-build.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 6cec97352b..658a0a5d39 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -875,13 +875,19 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
>      dsdt = tables_blob->len;
>      build_dsdt(tables_blob, tables->linker, vms);
>  
> -    /* FADT MADT GTDT MCFG SPCR pointed to by RSDT */
> +    /* FADT MADT PPTT GTDT MCFG SPCR pointed to by RSDT */
>      acpi_add_table(table_offsets, tables_blob);
>      build_fadt_rev5(tables_blob, tables->linker, vms, dsdt);
>  
>      acpi_add_table(table_offsets, tables_blob);
>      build_madt(tables_blob, tables->linker, vms);
>  
> +    if (!vmc->no_cpu_topology) {
> +        acpi_add_table(table_offsets, tables_blob);
> +        build_pptt(tables_blob, tables->linker, ms,
> +                   vms->oem_id, vms->oem_table_id);
> +    }
> +
>      acpi_add_table(table_offsets, tables_blob);
>      build_gtdt(tables_blob, tables->linker, vms);
>  
> 

Besides
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Eric



  reply	other threads:[~2021-10-20  8:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 13:21 [PATCH v8 0/8] hw/arm/virt: Introduce cpu topology support Yanan Wang
2021-10-14 13:21 ` [PATCH v8 1/8] hw/arm/virt: Only describe cpu topology since virt-6.2 Yanan Wang
2021-10-14 13:22 ` [PATCH v8 2/8] device_tree: Add qemu_fdt_add_path Yanan Wang
2021-10-14 13:22 ` [PATCH v8 3/8] hw/arm/virt: Add cpu-map to device tree Yanan Wang
2021-10-14 13:22 ` [PATCH v8 4/8] hw/acpi/aml-build: Add Processor hierarchy node structure Yanan Wang
2021-10-20  7:43   ` Eric Auger
2021-10-20  9:51     ` wangyanan (Y)
2021-10-20 10:04       ` Michael S. Tsirkin
2021-10-20 12:32         ` wangyanan (Y)
2021-10-14 13:22 ` [PATCH v8 5/8] hw/acpi/aml-build: Add PPTT table Yanan Wang
2021-10-20  8:02   ` Eric Auger
2021-10-20  9:51     ` wangyanan (Y)
2021-10-20 11:11       ` Eric Auger
2021-10-20 12:27         ` wangyanan (Y)
2021-10-20 12:43           ` Eric Auger
2021-10-20 12:53             ` wangyanan (Y)
2021-10-21  9:08               ` Andrew Jones
2021-10-21  9:25                 ` wangyanan (Y)
2021-10-14 13:22 ` [PATCH v8 6/8] tests/data/acpi/virt: Add an empty expected file for PPTT Yanan Wang
2021-10-20  1:41   ` wangyanan (Y)
2021-10-20  7:12   ` Eric Auger
2021-10-14 13:22 ` [PATCH v8 7/8] hw/arm/virt-acpi-build: Generate PPTT table Yanan Wang
2021-10-20  8:05   ` Eric Auger [this message]
2021-10-20  9:51     ` wangyanan (Y)
2021-10-14 13:22 ` [PATCH v8 8/8] tests/data/acpi/virt: Update the empty expected file for PPTT Yanan Wang
2021-10-20  1:41   ` wangyanan (Y)
2021-10-20  1:41 ` [PATCH v8 0/8] hw/arm/virt: Introduce cpu topology support wangyanan (Y)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66786f13-6603-1cdd-7ce7-b1c77f617ac8@redhat.com \
    --to=eauger@redhat.com \
    --cc=alistair.francis@wdc.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=drjones@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhaosl@gmail.com \
    --cc=wanghaibin.wang@huawei.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).