Re: [Qemu-devel] [PATCH v2] m68k: QOMify the MCF Fast Ethernet Controller device

[Jason Wang <jasowang@redhat.com>]

On 2017年01月08日 19:51, Thomas Huth wrote:
> When running qemu-system-m68k with the "-net" parameter (for example
> simply "-net nic -net user"), there is currently a confusing warning
> message saying:
>
>   Warning: requested NIC (anonymous, model mcf_fec) was not created
>   (not supported by this machine?)
>
> This seems to happen because the MCF NIC has never been adapted to
> the currently expected QEMU device behavior. Thus let's QOMify the
> NIC now to get rid of the warning message.
>
> Signed-off-by: Thomas Huth<huth@tuxfamily.org>
> ---
>   v2:
>   - Add the mcf_fec.h header file for the shared #defines
>   - Use qemu_check_nic_model() to verify the NIC model
>
>   hw/m68k/mcf5208.c         | 25 ++++++++++++++++-
>   hw/net/mcf_fec.c          | 71 +++++++++++++++++++++++++++++++++++------------
>   include/hw/m68k/mcf.h     |  4 ---
>   include/hw/m68k/mcf_fec.h | 13 +++++++++
>   4 files changed, 90 insertions(+), 23 deletions(-)
>   create mode 100644 include/hw/m68k/mcf_fec.h

Looks good, applied to -net.

Thanks