From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: Janosch Frank <frankja@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: define exit_reasons field in ArchPPC
Date: Fri, 20 May 2016 10:28:48 +0200 [thread overview]
Message-ID: <66904e6e-87bf-85fd-65ba-c09bacfe52ad@redhat.com> (raw)
In-Reply-To: <1463728077-6152-1-git-send-email-lvivier@redhat.com>
On 20/05/2016 09:07, Laurent Vivier wrote:
> Otherwise kvm_stat fails with the following error:
>
> AttributeError: 'ArchPPC' object has no attribute 'exit_reasons'
>
> This has been introduced by:
>
> 068294a scripts/kvm/kvm_stat: Group arch specific data
>
> Set exit_reasons to 'None' (as it is done for ArchS390) for ArchPPC.
>
> Test this with "kvm_stat -d" as tracepoints provider (-t) is
> also broken on PPC (looks like a kernel bug).
For this part, I've found the ioctl number used to reset the event queue
is not the good one on PPC (thanks to systemtap), I'm going to send
another patch to fix that too.
Laurent
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> scripts/kvm/kvm_stat | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 769d884..78ffe83 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -261,6 +261,7 @@ class ArchPPC(Arch):
> # numbers depend on the wordsize.
> char_ptr_size = ctypes.sizeof(ctypes.c_char_p)
> self.ioctl_numbers['SET_FILTER'] = 0x80002406 | char_ptr_size << 16
> + self.exit_reasons = None
>
> class ArchA64(Arch):
> def __init__(self):
>
prev parent reply other threads:[~2016-05-20 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 7:07 [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: define exit_reasons field in ArchPPC Laurent Vivier
2016-05-20 8:28 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66904e6e-87bf-85fd-65ba-c09bacfe52ad@redhat.com \
--to=lvivier@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).