Re: [Qemu-devel] [PULL 00/26] Audio 20190919 patches

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1343 bytes --]

On 9/19/19 10:15 AM, Peter Maydell wrote:
> On Thu, 19 Sep 2019 at 09:38, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>
>> The following changes since commit f8c3db33a5e863291182f8862ddf81618a7c6194:
>>
>>   target/sparc: Switch to do_transaction_failed() hook (2019-09-17 12:01:00 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://git.kraxel.org/qemu tags/audio-20190919-pull-request
>>
>> for you to fetch changes up to cf0c1c2aa32db5d658c3c797ad995a6d571bad96:
>>
>>   audio: fix ALSA period-length typo in documentation (2019-09-19 10:32:48 +0200)
>>
>> ----------------------------------------------------------------
>> audio: make mixeng optional.
>> audio: add surround sound support.
>> audio: documentation fixes.
>>
> 
> Hi; I'm afraid this fails to build on OSX/FreeBSD/OpenBSD/Windows,
> with format string issues:
> 
> /Users/pm215/src/qemu-for-merges/audio/wavaudio.c:50:15: error: format
> specifies type 'size_t' (aka 'unsigned long') but the argument has
> type 'int64_t' (aka 'long long') [-Werror,-Wformat]
>               bytes, strerror(errno));
>               ^~~~~

As long as you spin a v2, it's also worth fixing a typo I found in 15/26.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]