From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/2] target/arm: Move ID register field defs to cpu-features.h
Date: Wed, 24 Sep 2025 06:05:16 +0200 [thread overview]
Message-ID: <6691efc6-d79e-46c6-8b83-924a9a5940a3@linaro.org> (raw)
In-Reply-To: <20250923175751.966795-2-peter.maydell@linaro.org>
On 23/9/25 19:57, Peter Maydell wrote:
> Currently we define constants for the ID register fields in cpu.h.
> This means they're defined for a lot more code in QEMU than actually
> needs them. Move them to cpu-features.h, which is where we define
> the feature functions that test fields in these registers.
>
> There's only one place where we need to use some of these macro
> definitions that we weren't already including cpu-features.h:
> linux-user/arm/target_proc.h. Otherwise this patch is a pure
> movement of code from one file to the other.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> linux-user/arm/target_proc.h | 2 +
> target/arm/cpu-features.h | 410 +++++++++++++++++++++++++++++++++++
> target/arm/cpu.h | 410 -----------------------------------
> 3 files changed, 412 insertions(+), 410 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-09-24 4:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 17:57 [PATCH v2 0/2] target/arm: Implement ID_AA64PFR2_EL1 Peter Maydell
2025-09-23 17:57 ` [PATCH v2 1/2] target/arm: Move ID register field defs to cpu-features.h Peter Maydell
2025-09-24 4:05 ` Philippe Mathieu-Daudé [this message]
2025-09-23 17:57 ` [PATCH v2 2/2] target/arm: Implement ID_AA64PFR2_EL1 Peter Maydell
2025-09-24 4:08 ` Philippe Mathieu-Daudé
2025-09-23 20:08 ` [PATCH v2 0/2] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6691efc6-d79e-46c6-8b83-924a9a5940a3@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).