From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3841C2D0A8 for ; Wed, 23 Sep 2020 18:00:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 487E72223E for ; Wed, 23 Sep 2020 18:00:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EXRc28SH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 487E72223E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL93m-0004Rs-8f for qemu-devel@archiver.kernel.org; Wed, 23 Sep 2020 14:00:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL91K-0002KW-HE for qemu-devel@nongnu.org; Wed, 23 Sep 2020 13:57:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:53117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kL91I-0005Bq-Hs for qemu-devel@nongnu.org; Wed, 23 Sep 2020 13:57:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600883851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jFKErkGbc7xm7gW471cs1Lm8dwTOCXeL8be5i112L/Q=; b=EXRc28SHA9UaxSj2a0npCHAd2gsgs0L14w/oRuTPomnPX4/vBmY7AInQPV1ETVpGflm+ga 0+lkUZTwEn77fnz8Rvndh11JOE1AmHSyChoCZJb6niZ4xSwKw7pGg1unFVmAzfGmwkXEAt K+Pd1Wlw8TQ5kPjLyyax/Pd5lPyZSHs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-T-9swYJsP6C8Qt-VTReHZw-1; Wed, 23 Sep 2020 13:57:28 -0400 X-MC-Unique: T-9swYJsP6C8Qt-VTReHZw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37AA681F002; Wed, 23 Sep 2020 17:57:27 +0000 (UTC) Received: from [10.10.119.140] (ovpn-119-140.rdu2.redhat.com [10.10.119.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id F321760BEC; Wed, 23 Sep 2020 17:57:25 +0000 (UTC) Subject: Re: [PATCH v2 13/38] qapi/common.py: add type hint annotations To: Eduardo Habkost References: <20200922210101.4081073-1-jsnow@redhat.com> <20200922210101.4081073-14-jsnow@redhat.com> <20200922224428.GN2044576@habkost.net> From: John Snow Message-ID: <66a42a9a-d330-c4a9-e4b9-55b78668704b@redhat.com> Date: Wed, 23 Sep 2020 13:57:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200922224428.GN2044576@habkost.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=63.128.21.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/23 00:53:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.228, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Michael Roth , qemu-devel@nongnu.org, Markus Armbruster , Cleber Rosa , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/22/20 6:44 PM, Eduardo Habkost wrote: > Does this need to require a Sequence? It looks like it could be > Iterable. > > I don't think this should block the patch, though, so: > > Reviewed-by: Eduardo Habkost gen_if can take an Iterator, gen_endif needs a Sequence because it uses reversed(). I have not been very fastidious about choosing the MOST possibly abstracted type, but you are right that we SHOULD. I was hoping to find all occurrences of List and try slackening them to Collection/Sequence/Iterable etc, but as a follow-up. In this case, since gen_endif actually does want the stricter type, I'm deciding to leave them as Sequence for signature parity. --js (P.S. in case it comes up in future review, there is a bug that prevents us from using Collection in 3.6: https://github.com/PyCQA/pylint/issues/2377 )