From: Jagannathan Raman <jag.raman@oracle.com>
To: qemu-devel@nongnu.org
Cc: eduardo@habkost.net, elena.ufimtseva@oracle.com,
john.g.johnson@oracle.com, berrange@redhat.com, bleal@redhat.com,
john.levon@nutanix.com, mst@redhat.com, armbru@redhat.com,
quintela@redhat.com, f4bug@amsat.org, marcandre.lureau@gmail.com,
stefanha@redhat.com, thanos.makatos@nutanix.com,
pbonzini@redhat.com, jag.raman@oracle.com, eblake@redhat.com,
dgilbert@redhat.com
Subject: [PATCH v5 10/18] vfio-user: instantiate vfio-user context
Date: Wed, 19 Jan 2022 16:41:59 -0500 [thread overview]
Message-ID: <66bb8c18bb5372f72aaa66d62f09258ec7775100.1642626515.git.jag.raman@oracle.com> (raw)
In-Reply-To: <cover.1642626515.git.jag.raman@oracle.com>
create a context with the vfio-user library to run a PCI device
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
---
hw/remote/vfio-user-obj.c | 78 +++++++++++++++++++++++++++++++++++++++
1 file changed, 78 insertions(+)
diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c
index 80757b0029..810a7c3943 100644
--- a/hw/remote/vfio-user-obj.c
+++ b/hw/remote/vfio-user-obj.c
@@ -41,6 +41,9 @@
#include "hw/remote/machine.h"
#include "qapi/error.h"
#include "qapi/qapi-visit-sockets.h"
+#include "qemu/notify.h"
+#include "sysemu/sysemu.h"
+#include "libvfio-user.h"
#define TYPE_VFU_OBJECT "x-vfio-user-server"
OBJECT_DECLARE_TYPE(VfuObject, VfuObjectClass, VFU_OBJECT)
@@ -82,13 +85,23 @@ struct VfuObject {
char *device;
Error *err;
+
+ Notifier machine_done;
+
+ vfu_ctx_t *vfu_ctx;
};
+static void vfu_object_init_ctx(VfuObject *o, Error **errp);
+
static void vfu_object_set_socket(Object *obj, Visitor *v, const char *name,
void *opaque, Error **errp)
{
VfuObject *o = VFU_OBJECT(obj);
+ if (o->vfu_ctx) {
+ return;
+ }
+
qapi_free_SocketAddress(o->socket);
o->socket = NULL;
@@ -104,17 +117,68 @@ static void vfu_object_set_socket(Object *obj, Visitor *v, const char *name,
}
trace_vfu_prop("socket", o->socket->u.q_unix.path);
+
+ vfu_object_init_ctx(o, errp);
}
static void vfu_object_set_device(Object *obj, const char *str, Error **errp)
{
VfuObject *o = VFU_OBJECT(obj);
+ if (o->vfu_ctx) {
+ return;
+ }
+
g_free(o->device);
o->device = g_strdup(str);
trace_vfu_prop("device", str);
+
+ vfu_object_init_ctx(o, errp);
+}
+
+/*
+ * TYPE_VFU_OBJECT depends on the availability of the 'socket' and 'device'
+ * properties. It also depends on devices instantiated in QEMU. These
+ * dependencies are not available during the instance_init phase of this
+ * object's life-cycle. As such, the server is initialized after the
+ * machine is setup. machine_init_done_notifier notifies TYPE_VFU_OBJECT
+ * when the machine is setup, and the dependencies are available.
+ */
+static void vfu_object_machine_done(Notifier *notifier, void *data)
+{
+ VfuObject *o = container_of(notifier, VfuObject, machine_done);
+ Error *err = NULL;
+
+ vfu_object_init_ctx(o, &err);
+
+ if (err) {
+ error_propagate(&error_abort, err);
+ }
+}
+
+static void vfu_object_init_ctx(VfuObject *o, Error **errp)
+{
+ ERRP_GUARD();
+
+ if (o->vfu_ctx || !o->socket || !o->device ||
+ !phase_check(PHASE_MACHINE_READY)) {
+ return;
+ }
+
+ if (o->err) {
+ error_propagate(errp, o->err);
+ o->err = NULL;
+ return;
+ }
+
+ o->vfu_ctx = vfu_create_ctx(VFU_TRANS_SOCK, o->socket->u.q_unix.path, 0,
+ o, VFU_DEV_TYPE_PCI);
+ if (o->vfu_ctx == NULL) {
+ error_setg(errp, "vfu: Failed to create context - %s", strerror(errno));
+ return;
+ }
}
static void vfu_object_init(Object *obj)
@@ -124,6 +188,11 @@ static void vfu_object_init(Object *obj)
k->nr_devs++;
+ if (!phase_check(PHASE_MACHINE_READY)) {
+ o->machine_done.notify = vfu_object_machine_done;
+ qemu_add_machine_init_done_notifier(&o->machine_done);
+ }
+
if (!object_dynamic_cast(OBJECT(current_machine), TYPE_REMOTE_MACHINE)) {
error_setg(&o->err, "vfu: %s only compatible with %s machine",
TYPE_VFU_OBJECT, TYPE_REMOTE_MACHINE);
@@ -142,6 +211,10 @@ static void vfu_object_finalize(Object *obj)
o->socket = NULL;
+ if (o->vfu_ctx) {
+ vfu_destroy_ctx(o->vfu_ctx);
+ }
+
g_free(o->device);
o->device = NULL;
@@ -149,6 +222,11 @@ static void vfu_object_finalize(Object *obj)
if (!k->nr_devs && k->auto_shutdown) {
qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
}
+
+ if (o->machine_done.notify) {
+ qemu_remove_machine_init_done_notifier(&o->machine_done);
+ o->machine_done.notify = NULL;
+ }
}
static void vfu_object_class_init(ObjectClass *klass, void *data)
--
2.20.1
next prev parent reply other threads:[~2022-01-19 21:59 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 21:41 [PATCH v5 00/18] vfio-user server in QEMU Jagannathan Raman
2022-01-19 21:41 ` [PATCH v5 01/18] configure, meson: override C compiler for cmake Jagannathan Raman
2022-01-20 13:27 ` Paolo Bonzini
2022-01-20 15:21 ` Jag Raman
2022-02-17 6:10 ` Jag Raman
2022-01-19 21:41 ` [PATCH v5 02/18] tests/avocado: Specify target VM argument to helper routines Jagannathan Raman
2022-01-25 9:40 ` Stefan Hajnoczi
2022-01-19 21:41 ` [PATCH v5 03/18] pci: isolated address space for PCI bus Jagannathan Raman
2022-01-20 0:12 ` Michael S. Tsirkin
2022-01-20 15:20 ` Jag Raman
2022-01-25 18:38 ` Dr. David Alan Gilbert
2022-01-26 5:27 ` Jag Raman
2022-01-26 9:45 ` Stefan Hajnoczi
2022-01-26 20:07 ` Dr. David Alan Gilbert
2022-01-26 21:13 ` Michael S. Tsirkin
2022-01-27 8:30 ` Stefan Hajnoczi
2022-01-27 12:50 ` Michael S. Tsirkin
2022-01-27 21:22 ` Alex Williamson
2022-01-28 8:19 ` Stefan Hajnoczi
2022-01-28 9:18 ` Stefan Hajnoczi
2022-01-31 16:16 ` Alex Williamson
2022-02-01 9:30 ` Stefan Hajnoczi
2022-02-01 15:24 ` Alex Williamson
2022-02-01 21:24 ` Jag Raman
2022-02-01 22:47 ` Alex Williamson
2022-02-02 1:13 ` Jag Raman
2022-02-02 5:34 ` Alex Williamson
2022-02-02 9:22 ` Stefan Hajnoczi
2022-02-10 0:08 ` Jag Raman
2022-02-10 8:02 ` Michael S. Tsirkin
2022-02-10 22:23 ` Jag Raman
2022-02-10 22:53 ` Michael S. Tsirkin
2022-02-10 23:46 ` Jag Raman
2022-02-10 23:17 ` Alex Williamson
2022-02-10 23:28 ` Michael S. Tsirkin
2022-02-10 23:49 ` Alex Williamson
2022-02-11 0:26 ` Michael S. Tsirkin
2022-02-11 0:54 ` Jag Raman
2022-02-11 0:10 ` Jag Raman
2022-02-02 9:30 ` Peter Maydell
2022-02-02 10:06 ` Michael S. Tsirkin
2022-02-02 15:49 ` Alex Williamson
2022-02-02 16:53 ` Michael S. Tsirkin
2022-02-02 17:12 ` Alex Williamson
2022-02-01 10:42 ` Dr. David Alan Gilbert
2022-01-26 18:13 ` Dr. David Alan Gilbert
2022-01-27 17:43 ` Jag Raman
2022-01-25 9:56 ` Stefan Hajnoczi
2022-01-25 13:49 ` Jag Raman
2022-01-25 14:19 ` Stefan Hajnoczi
2022-01-19 21:41 ` [PATCH v5 04/18] pci: create and free isolated PCI buses Jagannathan Raman
2022-01-25 10:25 ` Stefan Hajnoczi
2022-01-25 14:10 ` Jag Raman
2022-01-19 21:41 ` [PATCH v5 05/18] qdev: unplug blocker for devices Jagannathan Raman
2022-01-25 10:27 ` Stefan Hajnoczi
2022-01-25 14:43 ` Jag Raman
2022-01-26 9:32 ` Stefan Hajnoczi
2022-01-26 15:13 ` Jag Raman
2022-01-19 21:41 ` [PATCH v5 06/18] vfio-user: add HotplugHandler for remote machine Jagannathan Raman
2022-01-25 10:32 ` Stefan Hajnoczi
2022-01-25 18:12 ` Jag Raman
2022-01-26 9:35 ` Stefan Hajnoczi
2022-01-26 15:20 ` Jag Raman
2022-01-26 15:43 ` Stefan Hajnoczi
2022-01-19 21:41 ` [PATCH v5 07/18] vfio-user: set qdev bus callbacks " Jagannathan Raman
2022-01-25 10:44 ` Stefan Hajnoczi
2022-01-25 21:12 ` Jag Raman
2022-01-26 9:37 ` Stefan Hajnoczi
2022-01-26 15:51 ` Jag Raman
2022-01-19 21:41 ` [PATCH v5 08/18] vfio-user: build library Jagannathan Raman
2022-01-19 21:41 ` [PATCH v5 09/18] vfio-user: define vfio-user-server object Jagannathan Raman
2022-01-25 14:40 ` Stefan Hajnoczi
2022-01-19 21:41 ` Jagannathan Raman [this message]
2022-01-25 14:44 ` [PATCH v5 10/18] vfio-user: instantiate vfio-user context Stefan Hajnoczi
2022-01-19 21:42 ` [PATCH v5 11/18] vfio-user: find and init PCI device Jagannathan Raman
2022-01-25 14:48 ` Stefan Hajnoczi
2022-01-26 3:14 ` Jag Raman
2022-01-19 21:42 ` [PATCH v5 12/18] vfio-user: run vfio-user context Jagannathan Raman
2022-01-25 15:10 ` Stefan Hajnoczi
2022-01-26 3:26 ` Jag Raman
2022-01-19 21:42 ` [PATCH v5 13/18] vfio-user: handle PCI config space accesses Jagannathan Raman
2022-01-25 15:13 ` Stefan Hajnoczi
2022-01-19 21:42 ` [PATCH v5 14/18] vfio-user: handle DMA mappings Jagannathan Raman
2022-01-19 21:42 ` [PATCH v5 15/18] vfio-user: handle PCI BAR accesses Jagannathan Raman
2022-01-19 21:42 ` [PATCH v5 16/18] vfio-user: handle device interrupts Jagannathan Raman
2022-01-25 15:25 ` Stefan Hajnoczi
2022-01-19 21:42 ` [PATCH v5 17/18] vfio-user: register handlers to facilitate migration Jagannathan Raman
2022-01-25 15:48 ` Stefan Hajnoczi
2022-01-27 17:04 ` Jag Raman
2022-01-28 8:29 ` Stefan Hajnoczi
2022-01-28 14:49 ` Thanos Makatos
2022-02-01 3:49 ` Jag Raman
2022-02-01 9:37 ` Stefan Hajnoczi
2022-01-19 21:42 ` [PATCH v5 18/18] vfio-user: avocado tests for vfio-user Jagannathan Raman
2022-01-26 4:25 ` Philippe Mathieu-Daudé via
2022-01-26 15:12 ` Jag Raman
2022-01-25 16:00 ` [PATCH v5 00/18] vfio-user server in QEMU Stefan Hajnoczi
2022-01-26 5:04 ` Jag Raman
2022-01-26 9:56 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66bb8c18bb5372f72aaa66d62f09258ec7775100.1642626515.git.jag.raman@oracle.com \
--to=jag.raman@oracle.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=elena.ufimtseva@oracle.com \
--cc=f4bug@amsat.org \
--cc=john.g.johnson@oracle.com \
--cc=john.levon@nutanix.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=thanos.makatos@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).