From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent
Date: Fri, 9 Mar 2018 23:07:19 +0100 [thread overview]
Message-ID: <66bcb7ee-6d29-330e-328e-b0862c154a43@redhat.com> (raw)
In-Reply-To: <445cf418-6ab6-1638-8a95-ba8fe2efe475@redhat.com>
On 09.03.2018 20:00, Eric Blake wrote:
> On 03/09/2018 11:41 AM, Thomas Huth wrote:
>> On 09.03.2018 15:36, Eric Blake wrote:
>>> On 03/09/2018 12:13 AM, Thomas Huth wrote:
>>>> "-net" is clearly a legacy option. Yet we still use it in almost all
>>>> examples in the qemu documentation, and many other spots in the network
>>>> chapter. We should make it less prominent that users are not lured into
>>>> using it so often anymore. So instead of starting the network chapter
>>>> with
>>>> "-net nic" and documenting "-net <backend>" below "-netdev <backend>"
>>>> everywhere, all the "-net" related documentation is now moved to the
>>>> end
>>>> of the chapter. The new "--nic" option is moved to the beginning of the
>>>> chapter instead, with a new example that should demonstrate how "--nic"
>>>> can be used to shortcut "--device" with "--netdev".
>>>> And the examples in this chapter are changed to use the "--device" and
>>>> "--netdev" options or "--nic" instead of "-net nic -net <backend>".
>>>>
>
>>>> +@example
>>>> +qemu-system-i386 --netdev user,id=n1,ipv6=off
>>>> --device=e1000,netdev=n1,mac=52:54:98:76:54:32
>>>> +qemu-system-i386 --nic user,ipv6=off,model=e1000,mac=52:54:98:76:54:32
>>>> +@end example
>>>
>>> Nice example.
>>
>> ... but looks like I even got it wrong - it should be "--device e1000",
>> without "=". Will fix it.
>
> Really? As I understand it, both long-opt spellings work ('--long=opt'
> as one arg, and '--long' 'opt' as two args). So the only reason to drop
> '=' would be consistency with other examples.
$ qemu-system-x86_64 --device=e1000
qemu-system-x86_64: --device=e1000: invalid option
Does at least not work for me.
Thomas
next prev parent reply other threads:[~2018-03-09 22:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 6:13 [Qemu-devel] [PATCH] qemu-doc: Rework the network options chapter to make "-net" less prominent Thomas Huth
2018-03-09 14:36 ` Eric Blake
2018-03-09 17:41 ` Thomas Huth
2018-03-09 19:00 ` Eric Blake
2018-03-09 22:07 ` Thomas Huth [this message]
2018-03-09 22:33 ` Eric Blake
2018-03-09 14:41 ` Paolo Bonzini
2018-03-09 17:20 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66bcb7ee-6d29-330e-328e-b0862c154a43@redhat.com \
--to=thuth@redhat.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).