From: Michael Walle <michael@walle.cc>
To: Anthony Liguori <aliguori@amazon.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] ui/gtk.c does not check qemu_chr_be_can_write()
Date: Mon, 29 Sep 2014 15:15:11 +0200 [thread overview]
Message-ID: <66be66e8dfdeec976fc6c67c54cf587a@walle.cc> (raw)
Hi Anthony, Hi Gerd,
the GTK frontend does not respect the the "chr_can_read" hook. The
frontend just writes characters to the device using qemu_chr_be_write()
without checking if the device can receive any input
(qemu_chr_be_can_write()).
At least for my device model (hw/char/milkymist-uart.c), this results in
an assertion because the rx callback asserts if there is already a
character in the buffer. It assumes that the uart_rx callback is only
called, if the uart_can_rx callback returns a value >0.
Do I make a wrong assumption here?
-michael
next reply other threads:[~2014-09-29 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 13:15 Michael Walle [this message]
2014-09-30 8:45 ` [Qemu-devel] ui/gtk.c does not check qemu_chr_be_can_write() Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66be66e8dfdeec976fc6c67c54cf587a@walle.cc \
--to=michael@walle.cc \
--cc=aliguori@amazon.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).