From: Richard Henderson <richard.henderson@linaro.org>
To: "Michael Tokarev" <mjt@tls.msk.ru>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org
Cc: Beraldo Leal <bleal@redhat.com>, Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
Cleber Rosa <crosa@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: Re: [PATCH v2 2/4] linux-user/flatload: Take mmap_lock in load_flt_binary()
Date: Sun, 6 Oct 2024 08:23:07 -0700 [thread overview]
Message-ID: <66c2c949-ccb2-45d6-8d13-2c34ccbf5760@linaro.org> (raw)
In-Reply-To: <d7d4d868-08e5-40d5-9a19-5854db9828f8@tls.msk.ru>
On 10/6/24 01:51, Michael Tokarev wrote:
> 22.08.2024 12:50, Philippe Mathieu-Daudé wrote:
>> load_flt_binary() calls load_flat_file() -> page_set_flags().
>>
>> page_set_flags() must be called with the mmap_lock held,
>> otherwise it aborts:
>>
>> $ qemu-arm -L stm32/lib/ stm32/bin/busybox
>> qemu-arm: ../accel/tcg/user-exec.c:505: page_set_flags: Assertion `have_mmap_lock()'
>> failed.
>> Aborted (core dumped)
>>
>> Fix by taking the lock in load_flt_binary().
>>
>> Fixes: fbd3c4cff6 ("linux-user/arm: Mark the commpage executable")
>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2525
>
> This one seems like it should go to -stable, is it not?
Yes, I think so.
r~
next prev parent reply other threads:[~2024-10-06 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 9:50 [PATCH v2 0/4] linux-user/flatload: Take mmap_lock in load_flt_binary() Philippe Mathieu-Daudé
2024-08-22 9:50 ` [PATCH v2 1/4] accel/tcg: Make page_set_flags() documentation public Philippe Mathieu-Daudé
2024-08-22 9:50 ` [PATCH v2 2/4] linux-user/flatload: Take mmap_lock in load_flt_binary() Philippe Mathieu-Daudé
2024-10-06 8:51 ` Michael Tokarev
2024-10-06 15:23 ` Richard Henderson [this message]
2024-08-22 9:50 ` [PATCH v2 3/4] tests/avocado: Allow running user-mode tests Philippe Mathieu-Daudé
2024-08-22 9:50 ` [PATCH v2 4/4] tests/avocado: Run STM32 bFLT busybox binary in current directory Philippe Mathieu-Daudé
2024-08-22 11:08 ` Thomas Huth
2024-08-22 23:48 ` [PATCH v2 0/4] linux-user/flatload: Take mmap_lock in load_flt_binary() Richard Henderson
2024-10-05 23:04 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66c2c949-ccb2-45d6-8d13-2c34ccbf5760@linaro.org \
--to=richard.henderson@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).