qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Zhao Liu" <zhao1.liu@linux.intel.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>
Cc: qemu-devel@nongnu.org, Xiaoling Song <xiaoling.song@intel.com>,
	Zhao Liu <zhao1.liu@intel.com>,
	Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Subject: Re: [PATCH 5/8] tests/unit/test-smp-parse.c: Test "drawers" parameter in -smp
Date: Fri, 1 Mar 2024 08:56:39 +0100	[thread overview]
Message-ID: <66c7e6eb-ea79-49cb-a6e8-0015feb6aedc@redhat.com> (raw)
In-Reply-To: <20240118144857.2124034-6-zhao1.liu@linux.intel.com>

On 18/01/2024 15.48, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
> 
> Although drawer was introduced to -smp along with book by s390 machine,
> as a general topology level in QEMU that may be reused by other arches
> in the future, it is desirable to cover this parameter's parsing in a
> separate case.
> 
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   tests/unit/test-smp-parse.c | 89 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 89 insertions(+)


Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2024-03-01  7:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 14:48 [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases Zhao Liu
2024-01-18 14:48 ` [PATCH 1/8] tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology case Zhao Liu
2024-03-01  7:37   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 2/8] tests/unit/test-smp-parse.c: Bump max_cpus to 4096 Zhao Liu
2024-03-01  7:40   ` Thomas Huth
2024-03-01  7:59     ` Zhao Liu
2024-01-18 14:48 ` [PATCH 3/8] tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer Zhao Liu
2024-03-01  7:49   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 4/8] tests/unit/test-smp-parse.c: Test "books" parameter in -smp Zhao Liu
2024-03-01  7:52   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 5/8] tests/unit/test-smp-parse.c: Test "drawers" " Zhao Liu
2024-03-01  7:56   ` Thomas Huth [this message]
2024-01-18 14:48 ` [PATCH 6/8] tests/unit/test-smp-parse.c: Test "drawers" and "books" combination case Zhao Liu
2024-01-18 14:48 ` [PATCH 7/8] tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy Zhao Liu
2024-03-01  7:59   ` Thomas Huth
2024-01-18 14:48 ` [PATCH 8/8] tests/unit/test-smp-parse.c: Test smp_props.has_clusters Zhao Liu
2024-03-01  8:01   ` Thomas Huth
2024-01-29  2:37 ` [PATCH 0/8] tests/unit/test-smp-parse.c: Add more CPU topology test cases Song, Xiaoling
2024-01-29  9:38 ` Zhao Liu
2024-02-21  6:47   ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66c7e6eb-ea79-49cb-a6e8-0015feb6aedc@redhat.com \
    --to=thuth@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=nsg@linux.ibm.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=xiaoling.song@intel.com \
    --cc=zhao1.liu@intel.com \
    --cc=zhao1.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).