Re: [Qemu-devel] [PATCH] qapi: report the default CPU type for each machine

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

On 5/21/19 10:38 AM, Daniel P. Berrangé wrote:
> When user doesn't request any explicit CPU model with libvirt or QEMU,
> a machine type specific CPU model is picked. Currently there is no way
> to determine what this QEMU built-in default is, so libvirt cannot
> report this back to the user in the XML config.
> 
> This extends the "query-machines" QMP command so that it reports the
> default CPU model typename for each machine.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  qapi/misc.json | 6 +++++-
>  vl.c           | 4 ++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi/misc.json b/qapi/misc.json
> index 8b3ca4fdd3..0bb7995bd4 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -2018,12 +2018,16 @@
>  #
>  # @hotpluggable-cpus: cpu hotplug via -device is supported (since 2.7.0)
>  #
> +# @default-cpu-type: default CPU model typename if none is requested via
> +#                    the -cpu argument. (since 4.2.0)

4.1 is sufficient (unless you think this is so controversial as to miss
the current release cycle).

Otherwise,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]