From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: michael.roth@amd.com
Subject: Re: [PATCH 3/3] tests/unit/test-qmp-event: Replace fixture by global variables
Date: Wed, 22 Nov 2023 09:09:42 +0100 [thread overview]
Message-ID: <66e4519f-04d0-4c59-b62b-4852a739c100@redhat.com> (raw)
In-Reply-To: <20231122072456.2518816-4-armbru@redhat.com>
On 22/11/2023 08.24, Markus Armbruster wrote:
> The fixture buys us exactly nothing, as we need a global variable
> anyway, for test_qapi_event_emit(). Drop it.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/unit/test-qmp-event.c | 91 ++++++++++++-------------------------
> 1 file changed, 30 insertions(+), 61 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2023-11-22 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 7:24 [PATCH 0/3] tests/unit/test-qmp-event: Unconfuse Coverity & simplify Markus Armbruster
2023-11-22 7:24 ` [PATCH 1/3] tests/unit/test-qmp-event: Drop superfluous mutex Markus Armbruster
2023-11-22 8:03 ` Thomas Huth
2023-11-22 7:24 ` [PATCH 2/3] tests/unit/test-qmp-event: Simplify event emission check Markus Armbruster
2023-11-22 8:07 ` Thomas Huth
2023-11-22 7:24 ` [PATCH 3/3] tests/unit/test-qmp-event: Replace fixture by global variables Markus Armbruster
2023-11-22 8:09 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66e4519f-04d0-4c59-b62b-4852a739c100@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).