From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Chris Hofstaedtler <chris@hofstaedtler.name>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Yonggang Luo <luoyonggang@gmail.com>,
Samuel Thibault <samuel.thibault@gnu.org>
Subject: Re: [PATCH v2] meson: fix ncurses detection on macOS
Date: Fri, 1 Jan 2021 12:02:26 +0100 [thread overview]
Message-ID: <66ee4218-1641-5fc7-8a88-818722255f49@redhat.com> (raw)
In-Reply-To: <20201230221727.60579-1-chris@hofstaedtler.name>
On 12/30/20 11:17 PM, Chris Hofstaedtler wrote:
> Without this, meson fails with "curses package not usable" when using ncurses
> 6.2. Apparently the wide functions (addwstr, etc) are hidden behind the extra
> define, and meson does not define it at that detection stage.
>
> Regression from b01a4fd3bd7d6f2 ("configure: Define NCURSES_WIDECHAR if we're
> using curses"). The meson conversion has seen many iterations of the curses
> check, so pinpointing the exact commit breaking this is not so easy.
>
> Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Samuel Thibault <samuel.thibault@gnu.org>
> Cc: Yonggang Luo <luoyonggang@gmail.com>
> ---
> meson.build | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Suggested-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2021-01-01 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 22:17 [PATCH v2] meson: fix ncurses detection on macOS Chris Hofstaedtler
2020-12-30 22:19 ` Samuel Thibault
2020-12-31 15:05 ` 罗勇刚(Yonggang Luo)
2021-01-01 11:02 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66ee4218-1641-5fc7-8a88-818722255f49@redhat.com \
--to=philmd@redhat.com \
--cc=chris@hofstaedtler.name \
--cc=luoyonggang@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).