Re: [Qemu-devel] ?==?utf-8?q? [PULL v5 00/46] MIPS queue August 2018 v5

["Aleksandar Markovic" <Aleksandar.Markovic@rt-rk.com>]

> On 23 August 2018 at 15:18, Aleksandar Markovic
> <aleksandar.markovic@rt-rk.com> wrote:
> > From: Aleksandar Markovic <amarkovic@wavecomp.com>
> >
> > The following changes since commit 3392fbee4e435658733bbe9aab23392660558b59:
> >
> > Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging (2018-08-23 12:28:17 +0100)
> >
> > are available in the git repository at:
> >
> > https://github.com/AMarkovic/qemu tags/mips-queue-aug-2018
> >
> > for you to fetch changes up to e7133037c63d9d806f1a1f6c5a1906e658496cfa:
> >
> > target/mips: Add definition of nanoMIPS I7200 CPU (2018-08-23 16:11:35 +0200)
> >
> > ----------------------------------------------------------------
> > MIPS queue August 2018 v5
> >
> > The patches in this queue add support for core functionality and
> > system mode for nanoMIPS platform.
> >
> > v5: Corrected repository
> > v4: Fixed clang build errors for user mode configurationos.
> > v3: Fixed initial ('since') commit.
> > v2: Added missing 'Reviewed-by' lines
> >
>
> Hi -- I'm afraid this fails to build on hosts with no C++ compiler.
> (The OpenBSD VM in the tests/vm/ setup is an example of this.)
>
> Linking fails with
> x86_64-unknown-openbsd6.1-gcc-4.9.4: error: ../disas/nanomips.o: No
> such file or directory
>
> If you want to use a disassembler written in C++ you need
> sufficient checks in configure to ensure that it isn't
> configured in if there's no C++ compiler. Compare the
> handling of the AArch64 disassembler: in configure we do
> if test -n "${cxx}"; then
> disas_config "ARM_A64"
> fi
>
> and then in disas/Makefile.objs the relevant object files
> are included via "common-obj-$(CONFIG_ARM_A64_DIS)"
>
> You probably want a similar thing with a
> disas_config "NANOMIPS"
>
> thanks
> -- PMM


Hi, Peter,

I just sent (only a cover letter of) v6 of the pull request. The disassembler patch is excluded from this request, so only 45 patches.

Hope this would be OK.

Thanks,
Aleksandar