From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v2 3/3] Do not kick vcpus in TCG mode
Date: Mon, 11 Apr 2011 22:27:44 +0200 [thread overview]
Message-ID: <6716fa38e63b1b17a042ce007fd07677dd80c43e.1302553661.git.jan.kiszka@web.de> (raw)
In-Reply-To: <cover.1302553661.git.jan.kiszka@web.de>
In-Reply-To: <cover.1302553661.git.jan.kiszka@web.de>
From: Jan Kiszka <jan.kiszka@siemens.com>
In TCG mode, iothread and vcpus run in lock-step. So it's pointless to
send a signal from qemu_cpu_kick to the vcpu thread - if we got here,
the receiver already left the vcpu loop.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
cpus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpus.c b/cpus.c
index 41bec7c..82a7806 100644
--- a/cpus.c
+++ b/cpus.c
@@ -860,7 +860,7 @@ void qemu_cpu_kick(void *_env)
CPUState *env = _env;
qemu_cond_broadcast(env->halt_cond);
- if (!env->thread_kicked) {
+ if (kvm_enabled() && !env->thread_kicked) {
qemu_cpu_kick_thread(env);
env->thread_kicked = true;
}
--
1.7.1
next prev parent reply other threads:[~2011-04-12 1:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 20:27 [Qemu-devel] [PATCH v2 0/3] io-thread optimizations Jan Kiszka
2011-04-11 20:27 ` [Qemu-devel] [PATCH v2 1/3] Do not drop global mutex for polled main loop runs Jan Kiszka
2011-04-11 20:27 ` [Qemu-devel] [PATCH v2 2/3] Poll main loop after I/O events were received Jan Kiszka
2011-04-11 20:27 ` Jan Kiszka [this message]
2011-04-12 7:09 ` [Qemu-devel] [PATCH v2 0/3] io-thread optimizations Paolo Bonzini
2011-04-13 20:16 ` Aurelien Jarno
2011-04-14 7:14 ` Jan Kiszka
2011-04-14 13:45 ` Avi Kivity
2011-04-14 13:59 ` Anthony Liguori
2011-04-14 14:05 ` Avi Kivity
2011-04-25 18:35 ` Aurelien Jarno
2011-04-26 7:36 ` Jan Kiszka
2011-06-25 8:38 ` Jan Kiszka
2011-06-25 22:44 ` Andreas Färber
2011-06-26 9:11 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6716fa38e63b1b17a042ce007fd07677dd80c43e.1302553661.git.jan.kiszka@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).