From: Eric DeVolder <eric.devolder@oracle.com>
To: Ani Sinha <ani@anisinha.ca>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro
Date: Tue, 15 Feb 2022 13:47:39 -0600 [thread overview]
Message-ID: <67215820-c437-649f-86d0-17a6c3bfbfaa@oracle.com> (raw)
In-Reply-To: <20220215153140.128528-1-ani@anisinha.ca>
On 2/15/22 09:31, Ani Sinha wrote:
> This change is cosmetic. IS_UEFI_CPER_RECORD macro definition that was added
> as a part of the ERST implementation seems to be unused. Remove it.
>
> CC: Eric DeVolder <eric.devolder@oracle.com>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
Thanks!
Reviewed-by: Eric DeVolder <eric.devolder@oracle.com>
> ---
> hw/acpi/erst.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c
> index c0a23cf467..de509c2b48 100644
> --- a/hw/acpi/erst.c
> +++ b/hw/acpi/erst.c
> @@ -80,11 +80,6 @@
> #define UEFI_CPER_RECORD_MIN_SIZE 128U
> #define UEFI_CPER_RECORD_LENGTH_OFFSET 20U
> #define UEFI_CPER_RECORD_ID_OFFSET 96U
> -#define IS_UEFI_CPER_RECORD(ptr) \
> - (((ptr)[0] == 'C') && \
> - ((ptr)[1] == 'P') && \
> - ((ptr)[2] == 'E') && \
> - ((ptr)[3] == 'R'))
>
> /*
> * NOTE that when accessing CPER fields within a record, memcpy()
>
prev parent reply other threads:[~2022-02-15 19:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 15:31 [PATCH] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro Ani Sinha
2022-02-15 19:47 ` Eric DeVolder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67215820-c437-649f-86d0-17a6c3bfbfaa@oracle.com \
--to=eric.devolder@oracle.com \
--cc=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).