From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCTkS-0001mO-0m for qemu-devel@nongnu.org; Wed, 08 Nov 2017 12:02:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCTkM-00041G-9t for qemu-devel@nongnu.org; Wed, 08 Nov 2017 12:02:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36306) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCTkM-00040u-3d for qemu-devel@nongnu.org; Wed, 08 Nov 2017 12:02:38 -0500 References: <20171108152023.80780-1-marcel@redhat.com> <3722f599-31b4-adb6-270b-aff5819f1bd3@redhat.com> From: Marcel Apfelbaum Message-ID: <6722cc03-9311-c19b-3f26-4f0cc41a1770@redhat.com> Date: Wed, 8 Nov 2017 19:02:35 +0200 MIME-Version: 1.0 In-Reply-To: <3722f599-31b4-adb6-270b-aff5819f1bd3@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/pcie-pci-bridge: restrict to X86 and ARM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: mst@redhat.com, zuban32s@gmail.com, cohuck@redhat.com On 08/11/2017 18:52, Thomas Huth wrote: > On 08.11.2017 16:20, Marcel Apfelbaum wrote: >> The PCIE-PCI bridge is specific to "pure" PCI systems > Hi Thomas, > s/PCI/PCIe/ ? > In this context maybe it doesn't really matter, but if I'll send a v2 I'll make the change, sure. >> (on QEMU we have X86 and ARM), it does not make sense to >> have if in other archs. >> >> Reported-by: Thomas Huth >> Signed-off-by: Marcel Apfelbaum >> --- >> default-configs/arm-softmmu.mak | 1 + >> default-configs/i386-softmmu.mak | 1 + >> default-configs/x86_64-softmmu.mak | 1 + >> hw/pci-bridge/Makefile.objs | 3 ++- >> 4 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak >> index 5059d134c8..33934b1dc4 100644 >> --- a/default-configs/arm-softmmu.mak >> +++ b/default-configs/arm-softmmu.mak >> @@ -122,6 +122,7 @@ CONFIG_FSL_IMX25=y >> CONFIG_IMX_I2C=y >> >> CONFIG_PCIE_PORT=y >> +CONFIG_PCIE_PCI_BRIDGE=y > > Actually, why not simply use CONFIG_PCIE_PORT instead to determine > whether the PCIe-to-PCI bridge should be included? The device only makes > sense if there is a PCIe root port available on the system... > I thought about it, but then we should also change all the devices that makes sense only if connected to PCIe Root Ports, like Intel Upstream Ports (Switches) and maybe more. (otherwise people will start asking why it is different.) We could use CONFIG_PCIE_PCI_BRIDGE=CONFIG_PCIE_PORT or something but it looks weird. This is why I've chosen the "independent" config option. But, to be fair, I have nothing against your suggestion, let's see what others think. Thanks for the review, Marcel > Thomas >