From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50209C4167B for ; Mon, 22 Nov 2021 13:06:34 +0000 (UTC) Received: from localhost ([::1]:43088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mp91k-000312-UO for qemu-devel@archiver.kernel.org; Mon, 22 Nov 2021 08:06:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp90A-0001iy-7b for qemu-devel@nongnu.org; Mon, 22 Nov 2021 08:04:55 -0500 Received: from 4.mo548.mail-out.ovh.net ([188.165.42.229]:44601) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp906-000478-6N for qemu-devel@nongnu.org; Mon, 22 Nov 2021 08:04:53 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.109.146.28]) by mo548.mail-out.ovh.net (Postfix) with ESMTPS id 9DF8F20AD8; Mon, 22 Nov 2021 13:04:36 +0000 (UTC) Received: from kaod.org (37.59.142.103) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 22 Nov 2021 14:04:35 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-103G005588146fd-ee55-4250-8738-c053e21b29ee, 416F395970A38A0BC3BF4248461703C95BA59510) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <673145cf-f64c-2520-3ed5-dae2a16704e7@kaod.org> Date: Mon, 22 Nov 2021 14:04:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 35/35] test/tcg/ppc64le: Add float reference files Content-Language: en-US To: Richard Henderson , References: <20211119160502.17432-1-richard.henderson@linaro.org> <20211119160502.17432-36-richard.henderson@linaro.org> <41eda524-8e61-88e6-71ff-757fae97bc9b@kaod.org> <0e4d4227-4a67-7a6e-4f45-6416faebbc93@linaro.org> <45a736de-efe4-1638-65c7-28764c93248a@linaro.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <45a736de-efe4-1638-65c7-28764c93248a@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.103] X-ClientProxiedBy: DAG4EX1.mxp5.local (172.16.2.31) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: cba51174-a762-4329-b598-4a0784bf2787 X-Ovh-Tracer-Id: 10764447535829453731 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvuddrgeeggdeglecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeeigedvffekgeeftedutddttdevudeihfegudffkeeitdekkeetkefhffelveelleenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdqphhptgesnhhonhhgnhhurdhorhhg Received-SPF: pass client-ip=188.165.42.229; envelope-from=clg@kaod.org; helo=4.mo548.mail-out.ovh.net X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.097, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, danielhb413@gmail.com, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/22/21 12:16, Richard Henderson wrote: > On 11/22/21 10:43 AM, Richard Henderson wrote: >> On 11/21/21 6:47 PM, Cédric Le Goater wrote: >>> I am getting an error with this test. See below. >> ... >>>   ### Rounding to nearest >>>   from single: f32(-nan:0xffa00000) >>> -  to double: f64(-nan:0x00fff4000000000000) (INVALID) >>> +  to double: f64(-nan:0x00fff4000000000000) (OK) >> >> Well that's disconcerting. >> >> I can replicate this failure on an x86_64 host, but do not see the same error on a power9 ppc64le host. > > Bah.  The test case is buggy. > > It reads the fpscr for the flags *after* having gone through the printf for the result, at which point you are at the mercy of whatever other fp arithmetic libc chooses to do. > > Fixed with > > --- a/tests/tcg/multiarch/float_convs.c > +++ b/tests/tcg/multiarch/float_convs.c > @@ -51,8 +51,8 @@ static void convert_single_to_double(float input) > >      output = input; > > -    out_fmt = fmt_f64(output); >      flag_fmt = fmt_flags(); > +    out_fmt = fmt_f64(output); >      printf("  to double: %s (%s)\n", out_fmt, flag_fmt); >      free(out_fmt); >      free(flag_fmt); > > But this alone of course causes other "failures", because we've got some incorrect reference files. Looks fine. Will you send this patch independently ? The patchset doesn't seem to break anything. Thanks, C.