From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D61CECE58C for ; Wed, 9 Oct 2019 17:21:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61A7D206BB for ; Wed, 9 Oct 2019 17:21:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61A7D206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFe3-0001XP-Tr for qemu-devel@archiver.kernel.org; Wed, 09 Oct 2019 13:21:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43414) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI6zJ-0004by-2g for qemu-devel@nongnu.org; Wed, 09 Oct 2019 04:06:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI6zI-0005lb-67 for qemu-devel@nongnu.org; Wed, 09 Oct 2019 04:06:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50130) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iI6zI-0005lN-0h for qemu-devel@nongnu.org; Wed, 09 Oct 2019 04:06:24 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 272348E582 for ; Wed, 9 Oct 2019 08:06:23 +0000 (UTC) Received: by mail-wm1-f71.google.com with SMTP id 190so681531wme.4 for ; Wed, 09 Oct 2019 01:06:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q74ha9OdyhPm3qJhgJ85+EZI2hqHBo4gZcVQeqH6MgU=; b=fKXvE6R97bvw4IhKteabQqM6Svh8nf4loAaCczLOxXN7rvIs2Gln7Bgv933pu79nPz jc+Rt4WYT8H/UjFF8hXjaqc/R04pb5wGUAhhe9Lotnw+KJ6fugv0PTfZ8x6Y4idyw9ZV o56sn3RBmFHcKnZqQ/chHsS+0UTT0mJPSileUg20Kq4/3PEHxfUdti2OUdksnV+YCi88 aSXFb8jFislYvOoIo/42sZf2VPAADlWo37wgO3ShvvWSA3XbHR6+ox1N1TlMMMrFjodn ch5CQZuCoISCt2BMMYqLhx2YYYoF2HVZzUvuOEYJc7ACBTCXnZvdFmW6AJoRjUneuXwp cYAw== X-Gm-Message-State: APjAAAVUwxd9A/FeoyPvYIXhFOMI4xoHhLjCT4Yj0BWmQXWkZ4QEjLvt x8dpTuv6ePZQ/rO7XYRNUqZJImIt1nupQ2QDK64/dBvr6MDoAdUSzG4Xf7d0cER1WbX811iLjo3 Yui6raD98HICkdYI= X-Received: by 2002:adf:ef0f:: with SMTP id e15mr1837657wro.385.1570608381750; Wed, 09 Oct 2019 01:06:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqzURMAJ7vAXRdu3FKhkm40vp+KgdXTuqatIpx9qvS0DnbB4Qk3LeYwCpkEIQLwlwh+bStTdQQ== X-Received: by 2002:adf:ef0f:: with SMTP id e15mr1837629wro.385.1570608381497; Wed, 09 Oct 2019 01:06:21 -0700 (PDT) Received: from [192.168.10.150] ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id b7sm1446184wrx.56.2019.10.09.01.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Oct 2019 01:06:20 -0700 (PDT) Subject: Re: [PATCH v5 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE To: Tao Xu , rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com References: <20190929015718.19562-1-tao3.xu@intel.com> <20190929015718.19562-2-tao3.xu@intel.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <6762960d-80a6-be31-399d-f62e33b31f28@redhat.com> Date: Wed, 9 Oct 2019 10:06:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190929015718.19562-2-tao3.xu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jingqi.liu@intel.com, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 29/09/19 03:57, Tao Xu wrote: > + } else if (function == 7 && index == 0 && reg == R_ECX) { > + if (enable_cpu_pm) { > + ret |= CPUID_7_0_ECX_WAITPKG; This is incorrect. You should disable WAITPKG if !enable_cpu_pm, but you should not enable it forcefully if enable_cpu_pm is true. Paolo > + } else { > + ret &= ~CPUID_7_0_ECX_WAITPKG; > + }