From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH v2 2/3] tests/functional: fix formatting of exception args
Date: Fri, 29 Aug 2025 17:03:43 +0200 [thread overview]
Message-ID: <676d7a3d-3d38-4c68-be44-50967f00ee95@redhat.com> (raw)
In-Reply-To: <20250829142616.2633254-3-berrange@redhat.com>
On 29/08/2025 16.26, Daniel P. Berrangé wrote:
> The catch-all exception handler forgot the placeholder for
> the exception details.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/functional/qemu_test/asset.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py
> index b5a6136d36..5c74adf224 100644
> --- a/tests/functional/qemu_test/asset.py
> +++ b/tests/functional/qemu_test/asset.py
> @@ -173,7 +173,7 @@ def fetch(self):
> continue
> except Exception as e:
> tmp_cache_file.unlink()
> - raise AssetError(self, "Unable to download: " % e)
> + raise AssetError(self, "Unable to download: %s" % e)
>
> if not os.path.exists(tmp_cache_file):
> raise AssetError(self, "Download retries exceeded", transient=True)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-08-30 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 14:26 [PATCH v2 0/3] tests/functional: improve handling flaky downloads Daniel P. Berrangé
2025-08-29 14:26 ` [PATCH v2 1/3] tests/functional: enable force refresh of cached assets Daniel P. Berrangé
2025-08-29 21:16 ` Richard Henderson
2025-08-29 14:26 ` [PATCH v2 2/3] tests/functional: fix formatting of exception args Daniel P. Berrangé
2025-08-29 15:03 ` Thomas Huth [this message]
2025-08-29 21:19 ` Richard Henderson
2025-08-29 14:26 ` [PATCH v2 3/3] tests/functional: handle URLError when fetching assets Daniel P. Berrangé
2025-08-29 15:03 ` Thomas Huth
2025-08-29 21:21 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=676d7a3d-3d38-4c68-be44-50967f00ee95@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).