Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Cc'ing Pierrick

On 30/5/24 09:45, Philippe Mathieu-Daudé wrote:
> We are trying to unify all qemu-system-FOO to a single binary.
> In order to do that we need to remove QAPI target specific code.
> 
> @dump-skeys is only available on qemu-system-s390x. This series
> rename it as @dump-s390-skey, making it available on other
> binaries. We take care of backward compatibility via deprecation.
> 
> Philippe Mathieu-Daudé (4):
>    hw/s390x: Introduce the @dump-s390-skeys QMP command
>    hw/s390x: Introduce the 'dump_s390_skeys' HMP command
>    hw/s390x: Deprecate the HMP 'dump_skeys' command
>    hw/s390x: Deprecate the QMP @dump-skeys command
> 
>   docs/about/deprecated.rst  |  5 +++++
>   qapi/misc-target.json      |  5 +++++
>   qapi/misc.json             | 18 ++++++++++++++++++
>   include/monitor/hmp.h      |  1 +
>   hw/s390x/s390-skeys-stub.c | 24 ++++++++++++++++++++++++
>   hw/s390x/s390-skeys.c      | 19 +++++++++++++++++--
>   hmp-commands.hx            | 17 +++++++++++++++--
>   hw/s390x/meson.build       |  5 +++++
>   8 files changed, 90 insertions(+), 4 deletions(-)
>   create mode 100644 hw/s390x/s390-skeys-stub.c
>