qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: Ani Sinha <ani.sinha@nutanix.com>, Laine Stump <laine@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julia Suvorova <jusual@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Igor Mammedov <imammedo@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses
Date: Sat, 18 Apr 2020 15:48:10 +0300	[thread overview]
Message-ID: <67ca69f6-8d6b-8be0-72f2-b30a67edf200@gmail.com> (raw)
In-Reply-To: <AFEDBC1F-8536-4354-9C5E-9829C258B6E3@nutanix.com>

Hi Ani,

On 4/18/20 6:25 AM, Ani Sinha wrote:
> +Julia who implemented https://patchwork.kernel.org/patch/11388881/
>
>
>> On Apr 18, 2020, at 3:26 AM, Laine Stump <laine@redhat.com> wrote:
>>
>> On 4/17/20 12:35 PM, Ani Sinha wrote:
>>> +Laine
>>>> On Apr 17, 2020, at 9:39 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>>>>
>>>> Problem is, I think this is not something we can support with pcie or shpc.
>>>> I'm reluctant to add features that only ACPI can support,
>>>> we are trying to phase that out.
>>> Hmm. I see. We use conventional PCI and hence was looking for providing this feature for conventional PCI only. Laine might be able to throw some lights as to feasibility of the in PCIE world.
>> Sorry, my knowledge doesn't go that low. If there's a qemu option I can expose it in libvirt, but am by no means an expert of qemu internals or the pci/pcie specs :-)
>>
>> (BTW, I think in the past people have prevented enabling hot-unplug by unprivileged users in Windows with some sort of a "system policy" in Windows. (whatever that is - I don't use Windows, and have just heard this from others when discussing the problem).
>>

A PCIe Root Port or a PCI slot can or cannot support hot-plugging. 
Anything in the middle can't be done at PCIe/PCI level (as far as I know).
I think the answer can be at the modelling level. Use non hot-pluggable 
slots (or PCIe Root Ports without hot-plug support) for the devices
you don't want hot-unplugged, leave an empty PCI Bridge (or some PCIe 
Root Ports with hot-plug support) to be able to hot-plug devices.

Thanks,
Marcel

> My question to Julia is whether it is possible to disable just hot unplug but keep hot plugging for PCIE devices enabled using PCI_EXP_SLTCAP_HPC  or otherwise in Qemu?
>
>




  reply	other threads:[~2020-04-18 12:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-17 15:13 [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses Ani Sinha
2020-04-17 15:27 ` Michael S. Tsirkin
2020-04-17 15:36   ` Ani Sinha
2020-04-17 16:09     ` Michael S. Tsirkin
2020-04-17 16:35       ` Ani Sinha
2020-04-17 21:56         ` Laine Stump
2020-04-18  3:25           ` Ani Sinha
2020-04-18 12:48             ` Marcel Apfelbaum [this message]
2020-04-19  4:00               ` Ani Sinha
2020-04-20 15:04               ` Ani Sinha
2020-04-20 15:38                 ` Ani Sinha
2020-04-20 18:35                   ` Julia Suvorova
2020-04-20  9:24       ` Daniel P. Berrangé
2020-04-20 10:33         ` Ani Sinha
2020-04-20 11:40         ` Philippe Mathieu-Daudé
2020-04-20 15:02         ` Michael S. Tsirkin
2020-04-21 14:45           ` Ani Sinha
2020-04-21 15:02             ` Daniel P. Berrangé
2020-04-22 10:45               ` Ani Sinha
2020-04-24 15:23                 ` Ani Sinha
2020-04-24 18:44                   ` Eduardo Habkost
2020-04-27  9:06                     ` Ani Sinha
2020-04-29 15:32                     ` Igor Mammedov
2020-05-10 17:42                       ` Ani Sinha
2020-05-11 18:54                         ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67ca69f6-8d6b-8be0-72f2-b30a67edf200@gmail.com \
    --to=marcel.apfelbaum@gmail.com \
    --cc=ani.sinha@nutanix.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jusual@redhat.com \
    --cc=laine@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).