From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB9EC2D0A3 for ; Tue, 3 Nov 2020 16:10:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 400A822280 for ; Tue, 3 Nov 2020 16:10:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YlfRRUD4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 400A822280 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZytL-0004ZM-7E for qemu-devel@archiver.kernel.org; Tue, 03 Nov 2020 11:10:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZyTv-0001jQ-Me for qemu-devel@nongnu.org; Tue, 03 Nov 2020 10:44:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21144) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kZyTt-0005Gh-53 for qemu-devel@nongnu.org; Tue, 03 Nov 2020 10:44:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604418260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O9wU6jXtojgCGzepSQEAMEulAbfCvMjM+UoWLRSvWxA=; b=YlfRRUD4QhQD/wbfT2HlQoCZPI7zxJqUra/OaOSOLM0YXF7TVM1G4PC388zZrSRr1ivgbC bTQUoHvEiG9V9eQx7aMPNnr98LO+BHVS14YWKhe+uLQXt/S0WV6+bHPHofdH7fR44f2xNV sEC6yFgnOofwd9hUi0LdRPS1F4hWf40= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-95-j53PDuixOJalMaSCZMjkCQ-1; Tue, 03 Nov 2020 10:44:18 -0500 X-MC-Unique: j53PDuixOJalMaSCZMjkCQ-1 Received: by mail-wr1-f69.google.com with SMTP id e3so7976853wrn.19 for ; Tue, 03 Nov 2020 07:44:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O9wU6jXtojgCGzepSQEAMEulAbfCvMjM+UoWLRSvWxA=; b=aNa3LBV26p0Zj5ce7V9vBLMRZlt3xrOwpTEfgpZ8nLz5hc1fkmBXJwTT9mfsH75L4J p55uhyP0GKeEJSUesDwXHWgrL2nsRCYljNcSx2rxB1yUTHLwNhpdUgugp8JlATxEsS4Q ZY9Rj/mokfw7B/Wp5Vn3Sg2NbsR01vyoNBW3h6ZVRYJjEHlTkB9I54S2RvuPMAxR8VKt XATZzADjnxbz1MIqeALTaBd6jYYWWPKXPKTllOJSdUM37iVFZ7XO9CIHUfcRTKLlQVyG QbRMJUZ3x8MHfRlQpeDLzOixXNdYGdv9F2wYtKcs82hOJIboWEJ2GRPLl5PFyBd/JQ+X sn1w== X-Gm-Message-State: AOAM530iPtAqX4QbGu/6M2hr+7vz/ZN7qHxGQGQs4Mrbltna+6vmLmSP QqPhDL0AU+xsRsx6/LCPjKQ/++KwEJ1nA4L1AHPRit6k721icirMSwt8e48iE9h9dJx7cWKo76p zfZh5BW9AOtZwsRc= X-Received: by 2002:adf:f185:: with SMTP id h5mr11651843wro.10.1604418257366; Tue, 03 Nov 2020 07:44:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQyQ6HbmW0+k+anQppU/qwc9xv3BdNaa8qi7qDZIBg/ucloGokYhjSJ23HFGYxIGuX5OecOg== X-Received: by 2002:adf:f185:: with SMTP id h5mr11651819wro.10.1604418257158; Tue, 03 Nov 2020 07:44:17 -0800 (PST) Received: from [192.168.1.36] (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id a128sm2353484wmf.5.2020.11.03.07.44.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Nov 2020 07:44:16 -0800 (PST) Subject: Re: [PATCH-for-5.2 0/4] misc: Trivial format string fixes To: Greg Kurz References: <20201103112558.2554390-1-philmd@redhat.com> <64132d34-dbd9-03ee-6f11-a6908df025bf@linux.vnet.ibm.com> <20201103162019.299112a8@bahia.lan> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <67d34e6c-3f4e-4e17-a850-c16a75305c84@redhat.com> Date: Tue, 3 Nov 2020 16:44:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201103162019.299112a8@bahia.lan> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 00:03:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juan Quintela , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , qemu-devel@nongnu.org, Dov Murik , qemu-ppc@nongnu.org, Gerd Hoffmann , "Dr. David Alan Gilbert" , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/3/20 4:20 PM, Greg Kurz wrote: > On Tue, 3 Nov 2020 15:28:11 +0100 > Philippe Mathieu-Daudé wrote: > >> On 11/3/20 3:03 PM, Dov Murik wrote: >>> >>> On 03/11/2020 15:58, Dov Murik wrote: >>>> On 03/11/2020 13:25, Philippe Mathieu-Daudé wrote: >>>>> IIUC qemu-trivial@ doesn't queue patches during freeze, >>>>> >>>>> so it might be easier if patches are queued by respective >>>>> >>>>> subsystem maintainers. >>>>> >>>>> >>>>> >>>>> Philippe Mathieu-Daudé (4): >>>>> >>>>>    hw/display/cirrus_vga: Remove debugging code commented out >>>>> >>>>>    hw/display/cirrus_vga: Fix hexadecimal format string specifier >>>>> >>>>>    hw/ppc/spapr_tpm_proxy: Fix hexadecimal format string specifier >>>>> >>>>>    migration/ram: Fix hexadecimal format string specifier >>>>> >>>>> >>>>> >>>>>   hw/display/cirrus_vga.c | 20 +------------------- >>>>> >>>>>   migration/ram.c         |  2 +- >>>>> >>>>>   hw/ppc/trace-events     |  2 +- >>>>> >>>>>   3 files changed, 3 insertions(+), 21 deletions(-) >>>>> >>>>> >>>>> >>>> >>>> >>>> There's at least one more easy fix: >>>> >>>> hw/misc/trace-events:106:mos6522_get_next_irq_time(uint16_t latch, >>>> int64_t d, int64_t delta) "latch=%d counter=0x%"PRId64 " >>>> delta_next=0x%"PRId64 >> >> Indeed. >> >>>> >>>> but I have no idea how to test this. >>>> >>>> -Dov >>>> >>> >>> ... and one more in hw/usb/u2f-passthru.c:348 : >>> >>>         error_report("%s: Bad written size (req 0x%zu, val 0x%zd)", >>>                      TYPE_U2F_PASSTHRU, sizeof(host_packet), written); >> >> 'written' is signed, so this format looks correct... >> > > Irrespective of the sign, u and d shouldn't be used behind 0x Ah yes you are right =) Long day... So '0x%zx' in both cases. > >>> >>> Again, I have no idea how to test/trigger these areas in the code. >>> >>> -Dov >>> >> >> >