From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX6Vm-0007pt-GU for qemu-devel@nongnu.org; Thu, 04 Jan 2018 09:28:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX6Vi-0008KD-6H for qemu-devel@nongnu.org; Thu, 04 Jan 2018 09:28:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41282) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eX6Vh-0008Ix-W8 for qemu-devel@nongnu.org; Thu, 04 Jan 2018 09:28:46 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 834F280E45 for ; Thu, 4 Jan 2018 14:28:44 +0000 (UTC) References: <20180104142502.15175-1-stefanha@redhat.com> From: Paolo Bonzini Message-ID: <67d581de-b882-0677-a3de-4f9d542d49e0@redhat.com> Date: Thu, 4 Jan 2018 15:28:33 +0100 MIME-Version: 1.0 In-Reply-To: <20180104142502.15175-1-stefanha@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi-disk: release AioContext in unaligned WRITE SAME case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: famz@redhat.com On 04/01/2018 15:25, Stefan Hajnoczi wrote: > scsi_write_same_complete() can retry the write if the request was > unaligned. Make sure to release the AioContext when that code path is > taken! > > This patch fixes a hang when QEMU terminates after an unaligned WRITE > SAME request has been processed with dataplane. The hang occurs because > iothread_stop_all() cannot acquire the AioContext lock that was leaked > by the IOThread in scsi_write_same_complete(). > > Fixes: b9e413dd37 > ("block: explicitly acquire aiocontext in aio callbacks that need it"). > Cc: Paolo Bonzini > Reported-by: Cong Li > Signed-off-by: Stefan Hajnoczi > --- > hw/scsi/scsi-disk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c > index e58833a087..49d2559d93 100644 > --- a/hw/scsi/scsi-disk.c > +++ b/hw/scsi/scsi-disk.c > @@ -1755,6 +1755,7 @@ static void scsi_write_same_complete(void *opaque, int ret) > data->sector << BDRV_SECTOR_BITS, > &data->qiov, 0, > scsi_write_same_complete, data); > + aio_context_release(blk_get_aio_context(s->qdev.conf.blk)); > return; > } > > Queued,t hanks! Paolo