From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/6] pr-manager-helper: report event on connection/disconnection
Date: Thu, 28 Jun 2018 15:24:24 -0500 [thread overview]
Message-ID: <67ddeac6-c110-5969-e6fb-847a773aa2d8@redhat.com> (raw)
In-Reply-To: <1530215858-1525-7-git-send-email-pbonzini@redhat.com>
On 06/28/2018 02:57 PM, Paolo Bonzini wrote:
> Let management know if there were any problems communicating with
> qemu-pr-helper. The event is edge-triggered, and is sent every time
> the connection status of the pr-manager-helper object changes.
Is this something that guest actions can intentionally trigger, and thus
cause a DoS attack by flooding the management app with events faster
than they can process? If so, this event should use rate-limiting.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> qapi/block.json | 24 ++++++++++++++++++++++++
> scsi/pr-manager-helper.c | 14 ++++++++++++++
> 2 files changed, 38 insertions(+)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-06-28 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 19:57 [Qemu-devel] [PATCH v2 0/6] pr-manager/qemu-pr-helper patches for QEMU 3.0 Paolo Bonzini
2018-06-28 19:57 ` [Qemu-devel] [PATCH 1/6] pr-helper: fix --socket-path default in help Paolo Bonzini
2018-06-28 19:57 ` [Qemu-devel] [PATCH 2/6] pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN Paolo Bonzini
2018-06-28 19:57 ` [Qemu-devel] [PATCH 3/6] pr-manager-helper: avoid SIGSEGV when writing to the socket fail Paolo Bonzini
2018-06-28 19:57 ` [Qemu-devel] [PATCH 4/6] pr-manager: put stubs in .c file Paolo Bonzini
2018-06-28 19:57 ` [Qemu-devel] [PATCH 5/6] pr-manager: add query-pr-managers QMP command Paolo Bonzini
2018-06-28 19:57 ` [Qemu-devel] [PATCH 6/6] pr-manager-helper: report event on connection/disconnection Paolo Bonzini
2018-06-28 20:24 ` Eric Blake [this message]
2018-06-29 10:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67ddeac6-c110-5969-e6fb-847a773aa2d8@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).