* [PATCH] scripts/get_maintainer.pl: don't print parentheses
@ 2023-10-13 9:16 Emmanouil Pitsidianakis
2023-10-13 10:43 ` Philippe Mathieu-Daudé
2023-10-13 10:45 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Emmanouil Pitsidianakis @ 2023-10-13 9:16 UTC (permalink / raw)
To: qemu-devel
Cc: Emmanouil Pitsidianakis, Philippe Mathieu-Daudé,
Paolo Bonzini
When called from git-send-email, some results contain unclosed
parentheses from the subsystem title, for example:
(cc-cmd) Adding cc: qemu-ppc@nongnu.org (open list:PowerNV (Non-Virt...) from: 'scripts/get_maintainer.pl --nogit-fallback'
(cc-cmd) Adding cc: qemu-devel@nongnu.org (open list:All patches CC here) from: 'scripts/get_maintainer.pl --nogit-fallback'
Unmatched () '(open list:PowerNV (Non-Virt...)' '' at /usr/lib/git-core/git-send-email line 642.
error: unable to extract a valid address from: qemu-ppc@nongnu.org (open list:PowerNV (Non-Virt...)
What to do with this address? ([q]uit|[d]rop|[e]dit): d
This commit removes all parentheses from results.
Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
---
scripts/get_maintainer.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 02fa828100..00a0870b26 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -907,6 +907,7 @@ sub get_subsystem_name {
if (length($subsystem) > 20) {
$subsystem = substr($subsystem, 0, 17);
$subsystem =~ s/\s*$//;
+ $subsystem =~ s/[()]//g;
$subsystem = $subsystem . "...";
}
return $subsystem;
base-commit: 63011373ad22c794a013da69663c03f1297a5c56
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/get_maintainer.pl: don't print parentheses
2023-10-13 9:16 [PATCH] scripts/get_maintainer.pl: don't print parentheses Emmanouil Pitsidianakis
@ 2023-10-13 10:43 ` Philippe Mathieu-Daudé
2023-10-13 10:45 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-13 10:43 UTC (permalink / raw)
To: Emmanouil Pitsidianakis, qemu-devel; +Cc: Paolo Bonzini
On 13/10/23 11:16, Emmanouil Pitsidianakis wrote:
> When called from git-send-email, some results contain unclosed
> parentheses from the subsystem title, for example:
>
> (cc-cmd) Adding cc: qemu-ppc@nongnu.org (open list:PowerNV (Non-Virt...) from: 'scripts/get_maintainer.pl --nogit-fallback'
> (cc-cmd) Adding cc: qemu-devel@nongnu.org (open list:All patches CC here) from: 'scripts/get_maintainer.pl --nogit-fallback'
> Unmatched () '(open list:PowerNV (Non-Virt...)' '' at /usr/lib/git-core/git-send-email line 642.
> error: unable to extract a valid address from: qemu-ppc@nongnu.org (open list:PowerNV (Non-Virt...)
> What to do with this address? ([q]uit|[d]rop|[e]dit): d
Eh thanks, this bugged me various times =)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> This commit removes all parentheses from results.
>
> Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
> ---
> scripts/get_maintainer.pl | 1 +
> 1 file changed, 1 insertion(+)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scripts/get_maintainer.pl: don't print parentheses
2023-10-13 9:16 [PATCH] scripts/get_maintainer.pl: don't print parentheses Emmanouil Pitsidianakis
2023-10-13 10:43 ` Philippe Mathieu-Daudé
@ 2023-10-13 10:45 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2023-10-13 10:45 UTC (permalink / raw)
To: Emmanouil Pitsidianakis; +Cc: qemu-devel, Philippe Mathieu-Daudé
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-13 10:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-13 9:16 [PATCH] scripts/get_maintainer.pl: don't print parentheses Emmanouil Pitsidianakis
2023-10-13 10:43 ` Philippe Mathieu-Daudé
2023-10-13 10:45 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).