From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] target/s390x: Fix missing clock-comparator interrupts after reset
Date: Wed, 15 Oct 2025 09:28:36 +0200 [thread overview]
Message-ID: <67f6a9617a0f128e75e0c8049041e81102518a16.camel@linux.ibm.com> (raw)
In-Reply-To: <20251014160743.398093-3-iii@linux.ibm.com>
On Tue, 2025-10-14 at 18:05 +0200, Ilya Leoshkevich wrote:
> After reset, both TOD and CKC values are set to 0, so if
^^^
This is inaccurate, only the TOD programmable register is set to 0.
I will fix this in v2.
> clock-comparator interrupts are enabled, one should occur shortly
> thereafter.
>
> Currently the code does not set tod_timer, so this does not happen.
>
> Fix by adding a tcg_s390_tod_updated() call. Initialize TOD clock
> before CPUs in order to ensure that the respective object exists
> during the CPU reset.
>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> hw/s390x/s390-virtio-ccw.c | 6 +++---
> target/s390x/cpu.c | 8 ++++++++
> 2 files changed, 11 insertions(+), 3 deletions(-)
[...]
next prev parent reply other threads:[~2025-10-15 7:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 16:05 [PATCH 0/3] target/s390x: Fix missing clock-comparator interrupts Ilya Leoshkevich
2025-10-14 16:05 ` [PATCH 1/3] target/s390x: Fix missing interrupts for small CKC values Ilya Leoshkevich
2025-10-15 13:01 ` Thomas Huth
2025-10-14 16:05 ` [PATCH 2/3] target/s390x: Fix missing clock-comparator interrupts after reset Ilya Leoshkevich
2025-10-15 7:28 ` Ilya Leoshkevich [this message]
2025-10-14 16:05 ` [PATCH 3/3] tests/tcg/s390x: Test SET CLOCK COMPARATOR Ilya Leoshkevich
2025-10-15 7:30 ` Ilya Leoshkevich
2025-10-15 7:56 ` [PATCH 0/3] target/s390x: Fix missing clock-comparator interrupts Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67f6a9617a0f128e75e0c8049041e81102518a16.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).