* [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category
@ 2025-02-18 15:54 BALATON Zoltan
2025-03-01 16:03 ` BALATON Zoltan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: BALATON Zoltan @ 2025-02-18 15:54 UTC (permalink / raw)
To: qemu-devel, qemu-ppc; +Cc: philmd
Add description and set category for eTSEC device so it shows up
better in -device help.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/net/fsl_etsec/etsec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index 3ce4fa2662..adde644892 100644
--- a/hw/net/fsl_etsec/etsec.c
+++ b/hw/net/fsl_etsec/etsec.c
@@ -423,8 +423,10 @@ static void etsec_class_init(ObjectClass *klass, void *data)
DeviceClass *dc = DEVICE_CLASS(klass);
dc->realize = etsec_realize;
+ dc->desc = "Freescale Enhanced Three-Speed Ethernet Controller";
device_class_set_legacy_reset(dc, etsec_reset);
device_class_set_props(dc, etsec_properties);
+ set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
}
static const TypeInfo etsec_types[] = {
--
2.30.9
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category
2025-02-18 15:54 [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category BALATON Zoltan
@ 2025-03-01 16:03 ` BALATON Zoltan
2025-03-02 20:46 ` Bernhard Beschow
2025-03-03 11:09 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: BALATON Zoltan @ 2025-03-01 16:03 UTC (permalink / raw)
To: qemu-devel, qemu-ppc; +Cc: philmd
On Tue, 18 Feb 2025, BALATON Zoltan wrote:
> Add description and set category for eTSEC device so it shows up
> better in -device help.
Ping?
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/net/fsl_etsec/etsec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
> index 3ce4fa2662..adde644892 100644
> --- a/hw/net/fsl_etsec/etsec.c
> +++ b/hw/net/fsl_etsec/etsec.c
> @@ -423,8 +423,10 @@ static void etsec_class_init(ObjectClass *klass, void *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> dc->realize = etsec_realize;
> + dc->desc = "Freescale Enhanced Three-Speed Ethernet Controller";
> device_class_set_legacy_reset(dc, etsec_reset);
> device_class_set_props(dc, etsec_properties);
> + set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
> }
>
> static const TypeInfo etsec_types[] = {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category
2025-02-18 15:54 [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category BALATON Zoltan
2025-03-01 16:03 ` BALATON Zoltan
@ 2025-03-02 20:46 ` Bernhard Beschow
2025-03-03 11:09 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Bernhard Beschow @ 2025-03-02 20:46 UTC (permalink / raw)
To: qemu-devel, BALATON Zoltan, qemu-ppc; +Cc: philmd
Am 18. Februar 2025 15:54:07 UTC schrieb BALATON Zoltan <balaton@eik.bme.hu>:
>Add description and set category for eTSEC device so it shows up
>better in -device help.
>
>Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>---
> hw/net/fsl_etsec/etsec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
>index 3ce4fa2662..adde644892 100644
>--- a/hw/net/fsl_etsec/etsec.c
>+++ b/hw/net/fsl_etsec/etsec.c
>@@ -423,8 +423,10 @@ static void etsec_class_init(ObjectClass *klass, void *data)
> DeviceClass *dc = DEVICE_CLASS(klass);
>
> dc->realize = etsec_realize;
>+ dc->desc = "Freescale Enhanced Three-Speed Ethernet Controller";
> device_class_set_legacy_reset(dc, etsec_reset);
> device_class_set_props(dc, etsec_properties);
>+ set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
> }
>
> static const TypeInfo etsec_types[] = {
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category
2025-02-18 15:54 [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category BALATON Zoltan
2025-03-01 16:03 ` BALATON Zoltan
2025-03-02 20:46 ` Bernhard Beschow
@ 2025-03-03 11:09 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-03 11:09 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel, qemu-ppc
On 18/2/25 16:54, BALATON Zoltan wrote:
> Add description and set category for eTSEC device so it shows up
> better in -device help.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/net/fsl_etsec/etsec.c | 2 ++
> 1 file changed, 2 insertions(+)
Patch queued, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-03 11:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-18 15:54 [PATCH] hw/net/fsl_etsec: Set eTSEC device description and category BALATON Zoltan
2025-03-01 16:03 ` BALATON Zoltan
2025-03-02 20:46 ` Bernhard Beschow
2025-03-03 11:09 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).