From: Eric Blake <eblake@redhat.com>
To: Antonio Ospite <ao2@ao2.it>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Antonio Ospite <antonio.ospite@collabora.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and make its definition more robust
Date: Mon, 6 May 2019 12:23:53 -0500 [thread overview]
Message-ID: <6822ade4-2859-6d2a-d778-7fc115af5081@redhat.com> (raw)
In-Reply-To: <20190503082728.16485-2-ao2@ao2.it>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On 5/3/19 3:27 AM, Antonio Ospite wrote:
> From: Antonio Ospite <antonio.ospite@collabora.com>
>
> Since commit 79d77bcd36 (configure: Remove --source-path option,
> 2019-04-29) source_path cannot be overridden anymore, move it out of the
> "default parameters" block since the word "default" may suggest that the
> value can change, while in fact it does not.
>
> While at it, only set source_path once and separate the positional
> argument of basename with "--" to more robustly cover the case of path
> names starting with a dash.
>
> Signed-off-by: Antonio Ospite <antonio.ospite@collabora.com>
> ---
> configure | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-06 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 8:27 [Qemu-devel] [PATCH v2 0/2] configure: disallow spaces and colons in source path and build path Antonio Ospite
2019-05-03 8:27 ` Antonio Ospite
2019-05-03 8:27 ` [Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and make its definition more robust Antonio Ospite
2019-05-03 8:27 ` Antonio Ospite
2019-05-06 17:23 ` Eric Blake [this message]
2019-05-03 8:27 ` [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path Antonio Ospite
2019-05-03 8:27 ` Antonio Ospite
2019-05-06 17:27 ` Eric Blake
2019-05-06 20:23 ` Antonio Ospite
2019-05-09 14:42 ` Peter Maydell
2019-05-22 13:57 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-05-22 15:01 ` Antonio Ospite
2019-05-22 15:21 ` Laurent Vivier
2019-05-22 15:26 ` Antonio Ospite
2019-05-22 15:37 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6822ade4-2859-6d2a-d778-7fc115af5081@redhat.com \
--to=eblake@redhat.com \
--cc=antonio.ospite@collabora.com \
--cc=ao2@ao2.it \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).