Re: [PATCH v5 15/16] iotests/image-fleecing: add test case with bitmap

[Hanna Reitz <hreitz@redhat.com>]

On 03.03.22 12:44, Hanna Reitz wrote:
> On 28.02.22 12:39, Vladimir Sementsov-Ogievskiy wrote:
>> Note that reads zero areas (not dirty in the bitmap) fails, that's
>> correct.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>   tests/qemu-iotests/tests/image-fleecing     | 32 ++++++--
>>   tests/qemu-iotests/tests/image-fleecing.out | 84 +++++++++++++++++++++
>>   2 files changed, 108 insertions(+), 8 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/tests/image-fleecing 
>> b/tests/qemu-iotests/tests/image-fleecing
>> index 909fc0a7ad..33995612be 100755
>> --- a/tests/qemu-iotests/tests/image-fleecing
>> +++ b/tests/qemu-iotests/tests/image-fleecing
>
> [...]
>
>> @@ -50,11 +50,15 @@ remainder = [('0xd5', '0x108000',  '32k'), # 
>> Right-end of partial-left [1]
>>                ('0xcd', '0x3ff0000', '64k')] # patterns[3]
>>     def do_test(use_cbw, use_snapshot_access_filter, base_img_path,
>> -            fleece_img_path, nbd_sock_path, vm):
>> +            fleece_img_path, nbd_sock_path, vm,
>> +            bitmap=False):
>>       log('--- Setting up images ---')
>>       log('')
>>         assert qemu_img('create', '-f', iotests.imgfmt, 
>> base_img_path, '64M') == 0
>> +    if bitmap:
>> +        assert qemu_img('bitmap', '--add', base_img_path, 'bitmap0') 
>> == 0
>
> Doing this means this test can only be run with qcow2, but right now 
> it claims to support many more formats that break with this patch 
> applied.  I think the supported_fmts list needs to be restricted.

Oh, and it will also need an `unsupported_imgopts=['compat']`.

> Also, iotest 297 complains about three lines being too long now.
>
>> +
>>       if use_snapshot_access_filter:
>>           assert use_cbw
>>           assert qemu_img('create', '-f', 'raw', fleece_img_path, 
>> '64M') == 0
>