From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: QEMU Summit Minutes 2023
Date: Wed, 29 Nov 2023 15:21:37 +0100 [thread overview]
Message-ID: <68337349-a8c7-4520-a381-a359bf8f8438@linaro.org> (raw)
In-Reply-To: <ZWYsMsgxjDZ_T2zA@redhat.com>
On 28/11/23 19:06, Daniel P. Berrangé wrote:
> On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote:
> Anyway, when a maintainer wants to merge a tree, I would expect to
> have a MR opened against 'master' in qemu-project/qemu. The CI
> ought to then run and if it is all green, then someone would approve
> it to merge to master.
>
>> It seems to me that we should also have a group of people approving
>> the MR.
>
> Yes, while we could have one designated gate keeper approving all
> MRs, that would defeat some of the benefit of MRs. So likely would
> be good to have a pool, and also setup the config so that the owner
> of an MR is not allow to approve their own MR, to guarantee there
> is always a 2nd pair of eyes as sanity check.
Are all our tests already on GitLab? Last time I remember Peter still
had manual tests.
next prev parent reply other threads:[~2023-11-29 14:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 13:21 QEMU Summit Minutes 2023 Peter Maydell
2023-08-17 6:13 ` Thomas Huth
2023-11-21 17:11 ` Alex Bennée
2023-11-28 17:54 ` Cédric Le Goater
2023-11-28 18:05 ` Peter Maydell
2023-11-28 18:09 ` Daniel P. Berrangé
2023-11-28 18:06 ` Daniel P. Berrangé
2023-11-29 14:21 ` Philippe Mathieu-Daudé [this message]
2023-11-29 15:45 ` Warner Losh
2023-11-29 15:47 ` Stefan Hajnoczi
2023-11-29 15:53 ` Stefan Hajnoczi
2023-11-29 16:46 ` Daniel P. Berrangé
2023-11-29 16:49 ` Stefan Hajnoczi
2023-11-29 16:57 ` Alex Bennée
2023-11-29 18:24 ` Stefan Hajnoczi
2023-11-29 15:50 ` Warner Losh
2023-11-29 16:49 ` Daniel P. Berrangé
2023-11-29 19:41 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68337349-a8c7-4520-a381-a359bf8f8438@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=clg@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).