From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKRjg-0003rb-MR for qemu-devel@nongnu.org; Wed, 29 Jul 2015 09:49:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZKRjb-0003L3-Nd for qemu-devel@nongnu.org; Wed, 29 Jul 2015 09:49:32 -0400 Received: from mx6-phx2.redhat.com ([209.132.183.39]:37776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZKRjb-0003Ky-GH for qemu-devel@nongnu.org; Wed, 29 Jul 2015 09:49:27 -0400 Date: Wed, 29 Jul 2015 08:43:08 -0400 (EDT) From: Thomas Huth Message-ID: <683562692.328057.1438173788965.JavaMail.zimbra@redhat.com> In-Reply-To: <1438172567-28227-1-git-send-email-cornelia.huck@de.ibm.com> References: <1438172567-28227-1-git-send-email-cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5] virtio: avoid leading underscores for helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, mst@redhat.com On Wednesday, July 29, 2015 2:22:47 PM, "Cornelia Huck" wrote: > > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > feature checking helpers") introduced a helper __virtio_has_feature. > We don't want to use reserved identifiers, though, so let's > rename __virtio_has_feature to virtio_has_feature and virtio_has_feature > to virtio_vdev_has_feature. "virtio_vdev_has_feature" is already a little bit long ... but I also fail come up with a better name, maybe "virtio_vdev_has_feat" ? Anyway, the patch also looks fine to me with the long name, so: Reviewed-by: Thomas Huth