From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC2AC433E0 for ; Thu, 4 Mar 2021 20:53:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FB6564F23 for ; Thu, 4 Mar 2021 20:53:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FB6564F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHuyb-0004m4-4J for qemu-devel@archiver.kernel.org; Thu, 04 Mar 2021 15:53:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHuv8-00009x-Hu for qemu-devel@nongnu.org; Thu, 04 Mar 2021 15:50:06 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:39142) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHuv6-0002PW-JM for qemu-devel@nongnu.org; Thu, 04 Mar 2021 15:50:06 -0500 Received: by mail-pl1-x62e.google.com with SMTP id j6so3287578plx.6 for ; Thu, 04 Mar 2021 12:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Jrxs1Pdwpo4GE5AjWraWRxP73dsGn+r9ZABbTNhRmZE=; b=XDkFgw+FQvUzXTBLTpCw4B2znOUwlSnTZGDtRG9qz3O+Qenjpll69Ec46oHRYny8DQ yRVRpVhdYeq3+/QZwtHyjtDO48qo2lj9m9X4RJtTCaFgX2tuH1cdjekxHQTmBmz5KJXP hq+wxAc6RTGU08yIGKx84LbBMTm+fyhATAJnN4tBL7sEAR6B0G2DVhNQWM8Y3QaJRFfq 4TUSDCNjqCGmlcLLZ/DvEUGeUSvUuxRg4VTKpWQU6tk7am6n5oD1bk56UOylM0ixZAij 6yxTgJkZn3uNObRSf11guAH7phNJWy9STtoEpflsN6sh17OVljamF2bliGNKfgmT/jK3 3WWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jrxs1Pdwpo4GE5AjWraWRxP73dsGn+r9ZABbTNhRmZE=; b=JX2bGZQZKTTR7QPxRaEhN1cPRuIWFdLu5nzLx9IpAglLxhdS/+KMIq5yvN2Pz1jEPS XRMbUxCn9/hSkJsLZm/ssvb/evr/jUD9wPlF5rQtQBN7MeCLuSGFWOuy2Prx1TRL9uz6 JL05GafW2un1sggsLpALSyCPrZtWwx6cI0TYjHD4kabGKEr1GrhyL9DptBMMoP6MIY4R wTrT54ysQTjeIA3DWi2kb9KvEio/q1LVcPTaXCBwgBfY6hq4v5n9hMT5JCVCaUg8RwZR LNuhxHQaDaTRxMkicUYIt4TZBAI4IFi1MqMz59jILaKDxtgI8EayH1LhSs3JGKL04siJ +csg== X-Gm-Message-State: AOAM53194w5MNrV2OSAH9Hyo6Rk+P/BF67UYkjZBCD2STElgEicmPG99 aqN7HsCvm+iaC2P2kKbY97iqX/vLFkMFFA== X-Google-Smtp-Source: ABdhPJxyftU7zwUWd+Y21T3w6yfSMc/UvIaAzuwTmNWsU0xqPrj2ZNB+NpChN+H5ZQoBi+XSgunv5g== X-Received: by 2002:a17:902:e8d2:b029:e3:c3e5:98ae with SMTP id v18-20020a170902e8d2b02900e3c3e598aemr5779208plg.78.1614891002825; Thu, 04 Mar 2021 12:50:02 -0800 (PST) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id w128sm264042pfw.86.2021.03.04.12.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 12:50:02 -0800 (PST) Subject: Re: [PATCH 38/44] hw/misc/mps2-fpgaio: Support AN547 DBGCTRL register To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210219144617.4782-1-peter.maydell@linaro.org> <20210219144617.4782-39-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <683afa5c-ad24-6caa-db28-6121651caee8@linaro.org> Date: Thu, 4 Mar 2021 12:50:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210219144617.4782-39-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/19/21 6:46 AM, Peter Maydell wrote: > For the AN547 image, the FPGAIO block has an extra DBGCTRL register, > which is used to control the SPNIDEN, SPIDEN, NPIDEN and DBGEN inputs > to the CPU. These signals control when the CPU permits use of the > external debug interface. Our CPU models don't implement the > external debug interface, so we model the register as > reads-as-written. > > Implement the register, with a property defining whether it is > present, and allow mps2-tz boards to specify that it is present. > > Signed-off-by: Peter Maydell > --- Reviewed-by: Richard Henderson r~