From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables
Date: Mon, 29 May 2017 10:55:00 -0500 [thread overview]
Message-ID: <683fd2c8-e98e-90e6-bf63-2b0e41236220@redhat.com> (raw)
In-Reply-To: <a412a3b6-37ec-f321-c6d6-aa754153cfe0@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
On 05/29/2017 10:46 AM, Max Reitz wrote:
>> If you switch all of these to $(realpath -- "$(type -p "$QEMU_...")"),
>> you can add:
>
> I'd love to, but this is what type -p outputs for me:
>
> $ type -p qemu-img
> qemu-img is /usr/bin/qemu-img
Huh? That's plain 'type' output. Are you sure you're testing 'type -p'?
$ PATH=$PATH # to forcefully clear bash's cache
$ type qemu-img
qemu-img is /usr/bin/qemu-img
$ type -p qemu-img
/usr/bin/qemu-img
$ qemu-img --help >/dev/null # to repopulate qemu-img into the cache
$ type qemu-img
qemu-img is hashed (/usr/bin/qemu-img)
$ type -p qemu-img
/usr/bin/qemu-img
>
> So I would need to parse the result (and it depends on the locale). If
> that is indeed so, I'd rather stay with which, to be honest...
Plain 'type' does have to be parsed, but 'type -p' is required to be
machine-usable.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-29 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 15:23 [Qemu-devel] [PATCH v3 0/2] iotests: Add test for colon handling Max Reitz
2017-05-29 15:23 ` [Qemu-devel] [PATCH v3 1/2] iotests: Use absolute paths for executables Max Reitz
2017-05-29 15:42 ` Eric Blake
2017-05-29 15:46 ` Max Reitz
2017-05-29 15:55 ` Eric Blake [this message]
2017-05-29 15:58 ` Max Reitz
2017-05-29 15:23 ` [Qemu-devel] [PATCH v3 2/2] iotests: Add test for colon handling Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=683fd2c8-e98e-90e6-bf63-2b0e41236220@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).