From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:44124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBGIW-0003f0-95 for qemu-devel@nongnu.org; Tue, 02 Apr 2019 06:05:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBGGO-00080R-SS for qemu-devel@nongnu.org; Tue, 02 Apr 2019 06:03:29 -0400 Received: from mx2.rt-rk.com ([89.216.37.149]:46410 helo=mail.rt-rk.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hBGGO-0007z6-Fn for qemu-devel@nongnu.org; Tue, 02 Apr 2019 06:03:28 -0400 References: <1553845000-6537-1-git-send-email-mateja.marjanovic@rt-rk.com> From: Mateja Marjanovic Message-ID: <6848c456-2369-3f18-7fd8-cfd4a9a76b8d@rt-rk.com> Date: Tue, 2 Apr 2019 12:03:25 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Qemu-devel] [PATCH v3 0/5] Add support for MSA instructions on a big endian host List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandar Markovic , "qemu-devel@nongnu.org" Cc: "aurelien@aurel32.net" , Aleksandar Rikalo On 1.4.19. 19:53, Aleksandar Markovic wrote: >> From: Mateja Marjanovic >> Subject: [PATCH v3 0/5] Add support for MSA instructions on a big endian host > "Add" -> "Fix" > > Big endian host support should have worked from the moment MSA > support is added to QEMU. I will change it in v4. > >> From: Mateja Marjanovic >> >> Add support for MSA instructions while executing QEMU on a >> machine that uses big endian MIPS CPU. Also change the >> implementation of helpers for MSA instructions >> ST., LD., INSERT. (and D on MIPS64), >> COPY_S. (and D on MIPS64) and COPY_U. (and W >> on MIPS64). Instead of using a switch in a helper, which is >> called many times, put a switch in translate.c file, which >> is called only a few times. >> > This paragraph suggests that there are essentially two independent > changes in this series (one for big endian host, another for refactoring > helpers), while in reality they are closely related. You should have > started the second sentence with "This is achieved by changing the > implementation of helpers for...". I will make it more clear in v4. > >> v3: >> - Unroll loops in ST. and LD. >> instructions. >> - Eliminate macro that generates the helpers for >> the ST. and LD. instructions, >> and add four helpers for each (for byte, >> halfword, word and doubleword). >> - Eliminate the helpers for INSERT., >> COPY_S. and COPY_U. and add >> four (three in case of COPY_U) helpers for >> each one. >> > The cover letter should contain the complete series history. I thought only the last version was necessary, but from now on I will write the complete series history. > > Thanks, > Aleksandar > >> Mateja Marjanovic (5): >> target/mips: MSA instructions ld, big endian host fix >> target/mips: MSA instructions st, big endian host fix >> target/mips: Different approach toward COPY_S MSA instr. and big >> endian fix >> target/mips: Different approach toward COPY_U MSA instr. and big >> endian fix >> target/mips: Different approach toward INSERT MSA instr. and big >> endian fix Thanks, Mateja