qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luca <kronos.it@gmail.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sf.net, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [kvm-devel] PIIX/IDE: ports disabled in PCI config space?
Date: Tue, 5 Jun 2007 15:09:33 +0200	[thread overview]
Message-ID: <68676e00706050609o10d0aa4fw8fbd7c850d0391f2@mail.gmail.com> (raw)
In-Reply-To: <46654E86.8010103@qumranet.com>

On 6/5/07, Avi Kivity <avi@qumranet.com> wrote:
> Luca Tettamanti wrote:
> > Hello,
> > I'm testing the new Fedora7 under KVM. As you may know Fedora has
> > migrated to the new libata drivers.
> >
> > ata_piix is unhappy with the PIIX IDE controller provided by QEmu/KVM:
> >
> >
> >
>
> [...]
>
> > The following patch fixes the problem (i.e. ata_piix finds both the HD
> > and the cdrom):
> >
> > --- a/hw/ide.c        2007-06-04 19:34:25.000000000 +0200
> > +++ b/hw/ide.c        2007-06-04 21:45:28.000000000 +0200
> > @@ -2586,6 +2586,8 @@ static void piix3_reset(PCIIDEState *d)
> >      pci_conf[0x06] = 0x80; /* FBC */
> >      pci_conf[0x07] = 0x02; // PCI_status_devsel_medium
> >      pci_conf[0x20] = 0x01; /* BMIBA: 20-23h */
> > +    pci_conf[0x41] = 0x80; // enable port 0
> > +    pci_conf[0x43] = 0x80; // enable port 1
> >  }
> >
> >  void pci_piix_ide_init(PCIBus *bus, BlockDriverState **hd_table, int devfn)
> >
>
> I imagine the reset state in the spec is disabled?

Yes, you are right.
Btw, this is the doc:
http://www.intel.com/design/intarch/datashts/290550.htm

> If so, then the
> long-term fix is to enable these bits in the bios.

Good point. I'm looking at bochs right now: the BIOS doesn't touch
that bits. The 2 ports are enabled/disabled - using values from the
config file - by the reset function of the emulated controller
(iodev/pci_ide.cc), so they're doing the same thing I've done for
QEMU.
I'd rather not touch the BIOS, it's a bit obscure ;-)

Luca

  reply	other threads:[~2007-06-05 13:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04 20:51 [Qemu-devel] PIIX/IDE: ports disabled in PCI config space? Luca Tettamanti
2007-06-05 11:52 ` [Qemu-devel] Re: [kvm-devel] " Avi Kivity
2007-06-05 13:09   ` Luca [this message]
2007-06-05 13:19     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68676e00706050609o10d0aa4fw8fbd7c850d0391f2@mail.gmail.com \
    --to=kronos.it@gmail.com \
    --cc=avi@qumranet.com \
    --cc=kvm-devel@lists.sf.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).