From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lfzka-0008In-VB
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:51:49 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lfzka-0008I4-FW
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:51:48 -0500
Received: from [199.232.76.173] (port=38374 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lfzka-0008Hu-8j
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:51:48 -0500
Received: from fg-out-1718.google.com ([72.14.220.153]:58362)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kronos.it@gmail.com>) id 1LfzkZ-00020L-Pj
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:51:47 -0500
Received: by fg-out-1718.google.com with SMTP id e21so650920fga.8
	for <qemu-devel@nongnu.org>; Sat, 07 Mar 2009 08:51:45 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <E1LfyjI-0007YY-45@cvs.savannah.gnu.org>
References: <E1LfyjI-0007YY-45@cvs.savannah.gnu.org>
Date: Sat, 7 Mar 2009 17:51:45 +0100
Message-ID: <68676e00903070851kf4b9bf5g30570c3830c7d9f0@mail.gmail.com>
Subject: Re: [Qemu-devel] [6737] Sparse fixes: truncation by cast
From: Luca Tettamanti <kronos.it@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, Mar 7, 2009 at 4:46 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> Revision: 6737
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0http://svn.sv.gnu.org/viewvc/?view=3Dre=
v&root=3Dqemu&revision=3D6737
> Author: =C2=A0 blueswir1
> Date: =C2=A0 =C2=A0 2009-03-07 15:46:23 +0000 (Sat, 07 Mar 2009)
> Log Message:
> -----------
> Sparse fixes: truncation by cast
>
> Fix Sparse warnings about constant truncation caused by cast
>
> Modified: trunk/bswap.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- trunk/bswap.h =C2=A0 =C2=A0 =C2=A0 2009-03-07 15:32:56 UTC (rev 6736)
> +++ trunk/bswap.h =C2=A0 =C2=A0 =C2=A0 2009-03-07 15:46:23 UTC (rev 6737)
> @@ -151,7 +151,7 @@
> =C2=A0{
> =C2=A0 =C2=A0 uint8_t *p1 =3D (uint8_t *)p;
>
> - =C2=A0 =C2=A0p1[0] =3D v;
> + =C2=A0 =C2=A0p1[0] =3D v & 0xff;
> =C2=A0 =C2=A0 p1[1] =3D v >> 8;

Hum, by the same principle the last line should be:
p1[1] =3D (v >> 8) & 0xff;
no?

Luca