From: Luca Tettamanti <kronos.it@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] r6677 broke access to physical FDD on Win32
Date: Mon, 23 Mar 2009 13:31:50 +0100 [thread overview]
Message-ID: <68676e00903230531p7c970a8ehfe4205600ddae382@mail.gmail.com> (raw)
In-Reply-To: <49C6A459.3000409@bttr-software.de>
On Sun, Mar 22, 2009 at 9:49 PM, Robert Riebisch <rr@bttr-software.de> wrote:
> --- block-raw-win32.co Wed Mar 4 22:54:44 2009
> +++ block-raw-win32.c Sat Mar 21 05:51:34 2009
> @@ -429,6 +431,10 @@
> }
> }
> s->type = find_device_type(bs, filename);
> + if (s->type == FTYPE_DISK)
> + share_flags = FILE_SHARE_READ | FILE_SHARE_WRITE;
> + else
> + share_flags = FILE_SHARE_READ;
This look dangerous (as in "the guest might corrupt the fs"), what it
the rationale behind this change?
Luca
next prev parent reply other threads:[~2009-03-23 12:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 21:53 [Qemu-devel] r6677 broke access to physical FDD on Win32 Robert Riebisch
2009-03-20 22:01 ` Anthony Liguori
2009-03-20 22:23 ` Robert Riebisch
2009-03-20 23:02 ` Anthony Liguori
2009-03-20 23:20 ` Luca Tettamanti
2009-03-21 1:56 ` Anthony Liguori
2009-03-22 20:49 ` Robert Riebisch
2009-03-23 2:20 ` Anthony Liguori
2009-03-23 12:31 ` Luca Tettamanti [this message]
2009-03-24 8:20 ` Japheth
2009-03-30 19:59 ` Robert Riebisch
2009-03-21 22:07 ` Luca Tettamanti
2009-04-07 1:46 ` Anthony Liguori
2009-04-07 11:45 ` Luca Tettamanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68676e00903230531p7c970a8ehfe4205600ddae382@mail.gmail.com \
--to=kronos.it@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).