From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LljJu-0005Nt-9Z
	for qemu-devel@nongnu.org; Mon, 23 Mar 2009 08:31:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LljJp-0005Kx-C8
	for qemu-devel@nongnu.org; Mon, 23 Mar 2009 08:31:57 -0400
Received: from [199.232.76.173] (port=34334 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LljJp-0005Kp-6M
	for qemu-devel@nongnu.org; Mon, 23 Mar 2009 08:31:53 -0400
Received: from mail-bw0-f172.google.com ([209.85.218.172]:57146)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kronos.it@gmail.com>) id 1LljJo-00020Q-RM
	for qemu-devel@nongnu.org; Mon, 23 Mar 2009 08:31:53 -0400
Received: by bwz20 with SMTP id 20so1526115bwz.34
	for <qemu-devel@nongnu.org>; Mon, 23 Mar 2009 05:31:50 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <49C6A459.3000409@bttr-software.de>
References: <49C16D71.7020104@bttr-software.de>
	<49C41240.8030102@codemonkey.ws> <49C4177B.7080405@bttr-software.de>
	<49C42080.5080802@codemonkey.ws>
	<68676e00903201620n1ac29c01g9e3d7172f9bc69a4@mail.gmail.com>
	<49C4493E.9050701@codemonkey.ws> <49C6A459.3000409@bttr-software.de>
Date: Mon, 23 Mar 2009 13:31:50 +0100
Message-ID: <68676e00903230531p7c970a8ehfe4205600ddae382@mail.gmail.com>
Subject: Re: [Qemu-devel] r6677 broke access to physical FDD on Win32
From: Luca Tettamanti <kronos.it@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Mar 22, 2009 at 9:49 PM, Robert Riebisch <rr@bttr-software.de> wrot=
e:
> --- block-raw-win32.co =C2=A0Wed Mar =C2=A04 22:54:44 2009
> +++ block-raw-win32.c =C2=A0 Sat Mar 21 05:51:34 2009
> @@ -429,6 +431,10 @@
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
> =C2=A0 =C2=A0 }
> =C2=A0 =C2=A0 s->type =3D find_device_type(bs, filename);
> + =C2=A0 =C2=A0if (s->type =3D=3D FTYPE_DISK)
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0share_flags =3D FILE_SHARE_READ | FILE_SHARE=
_WRITE;
> + =C2=A0 =C2=A0else
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0share_flags =3D FILE_SHARE_READ;

This look dangerous (as in "the guest might corrupt the fs"), what it
the rationale behind this change?

Luca