From: Luca Tettamanti <kronos.it@gmail.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] r6677 broke access to physical FDD on Win32
Date: Tue, 7 Apr 2009 13:45:19 +0200 [thread overview]
Message-ID: <68676e00904070445v10efa8dciea08a5bf0d3b3eff@mail.gmail.com> (raw)
In-Reply-To: <49DAB05E.5020906@us.ibm.com>
On Tue, Apr 7, 2009 at 3:46 AM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> Luca Tettamanti wrote:
>> The bug is here:
>> type = GetDriveType(s->drive_path);
>> if (type == DRIVE_CDROM)
>> return FTYPE_CD;
>> else
>> return FTYPE_FILE;
>>
>> GetDriveType("a:") returns DRIVE_REMOVABLE, which according to MSDN
>> means "The drive has removable media; for example, a floppy drive,
>> thumb drive, or flash card reader."; the code is not expecting such a
>> value so it sets the type to FTYPE_FILE; raw_getlength() then uses
>> GetFileSize() which of course fails...
>>
>> Here's a patch for properly handling the return value of GetDriveType
>> (sorry for the attachment, but I'm currently using a remote VM over
>> RDP and don't have a decent mailer installed).
>>
>
> Applied. Thanks.
There is also this patch floating around:
http://thread.gmane.org/gmane.comp.emulators.qemu/39851
which also addresses the lack of FILE_SHARE_WRITE flag.
Luca
prev parent reply other threads:[~2009-04-07 11:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 21:53 [Qemu-devel] r6677 broke access to physical FDD on Win32 Robert Riebisch
2009-03-20 22:01 ` Anthony Liguori
2009-03-20 22:23 ` Robert Riebisch
2009-03-20 23:02 ` Anthony Liguori
2009-03-20 23:20 ` Luca Tettamanti
2009-03-21 1:56 ` Anthony Liguori
2009-03-22 20:49 ` Robert Riebisch
2009-03-23 2:20 ` Anthony Liguori
2009-03-23 12:31 ` Luca Tettamanti
2009-03-24 8:20 ` Japheth
2009-03-30 19:59 ` Robert Riebisch
2009-03-21 22:07 ` Luca Tettamanti
2009-04-07 1:46 ` Anthony Liguori
2009-04-07 11:45 ` Luca Tettamanti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68676e00904070445v10efa8dciea08a5bf0d3b3eff@mail.gmail.com \
--to=kronos.it@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).