From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Foley <pefoley@google.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>, nabihestefan@google.com
Subject: Re: [PATCH] linux-user: Add missing includes
Date: Fri, 5 Sep 2025 09:31:13 +0200 [thread overview]
Message-ID: <687f76dc-769d-4e8d-9281-5e5f10361bfe@redhat.com> (raw)
In-Reply-To: <20250904-includes-v1-1-a04a0ea14fd1@google.com>
On 9/4/25 17:21, Peter Foley wrote:
> We're getting errors about this:
> linux-user/elfload.c:2770:36: error: use of undeclared identifier 'MAP_FIXED_NOREPLACE'
Queued, thanks.
Paolo
>
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
> linux-user/elfload.c | 1 +
> linux-user/mmap.c | 1 +
> linux-user/syscall.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 26c090c95d3e90ad4a23a927267e4106f68975b0..edbacf041f25d88472c95efb4eb9bdccd81e9902 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -5,6 +5,7 @@
> #include <sys/prctl.h>
> #include <sys/resource.h>
> #include <sys/shm.h>
> +#include <linux/mman.h>
>
> #include "qemu.h"
> #include "user/tswap-target.h"
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index 002e1e668e631130526053599e1d18ffb4b4141a..9e92117ca3e8e4f45cb333366ecf3668b8986200 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -18,6 +18,7 @@
> */
> #include "qemu/osdep.h"
> #include <sys/shm.h>
> +#include <linux/mman.h>
> #include "trace.h"
> #include "exec/log.h"
> #include "exec/page-protection.h"
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 91360a072c7f478085ac1c7cc8bb2026f8b32038..4101b0e4e7812740afe7a4246a902a5364d7c331 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -101,6 +101,7 @@
> #include <linux/soundcard.h>
> #include <linux/kd.h>
> #include <linux/mtio.h>
> +#include <linux/mman.h>
> #include <linux/fs.h>
> #include <linux/fd.h>
> #if defined(CONFIG_FIEMAP)
>
> ---
> base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
> change-id: 20250904-includes-19d9afaed67a
>
> Best regards,
next prev parent reply other threads:[~2025-09-05 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 15:21 [PATCH] linux-user: Add missing includes Peter Foley
2025-09-05 7:31 ` Paolo Bonzini [this message]
2025-09-05 8:48 ` Richard Henderson
2025-09-05 16:00 ` Peter Foley
2025-09-05 16:06 ` Peter Foley
2025-09-05 16:26 ` Richard Henderson
2025-09-05 16:28 ` Peter Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687f76dc-769d-4e8d-9281-5e5f10361bfe@redhat.com \
--to=pbonzini@redhat.com \
--cc=laurent@vivier.eu \
--cc=nabihestefan@google.com \
--cc=pefoley@google.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).